Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hard-code governance keys in SCM #5

Closed
turadg opened this issue Nov 2, 2023 · 1 comment · Fixed by #133
Closed

hard-code governance keys in SCM #5

turadg opened this issue Nov 2, 2023 · 1 comment · Fixed by #133
Assignees
Labels
enhancement New feature or request

Comments

@turadg
Copy link
Member

turadg commented Nov 2, 2023

What is the Problem Being Solved?

The governance keys are generated on each build, to prevent code from depending upon them. (Any code that did would break.)

This has a cost though to using the resulting build. Some of it can be automated (by pulling the key material from the image) but it's a royal pain with GUI tools like Keplr to update for each build.

Description of the Design

Generated the keys once and check the mnemonics into SCM. Have the build import those.

We still want to prevent logic depending on the specific keys. Code review may suffice but we've missed some before. Maybe a simple grep for agoric1 in proposals is worthwhile.

With the mnemonics not a secret, it might help to output them to logs for easy discovery.

@turadg
Copy link
Member Author

turadg commented Mar 19, 2024

I just noticed that VALIDATORADDR is actually a delegator. I hacked around it downstream with https://github.com/Agoric/agoric-sdk/blob/f8b99f2bbe8bf579b5b42b68813f9c231f941a0b/a3p-integration/proposals/c:stake-bld/test.sh but when this issue is tackled it should include an upsteam fix.

@LuqiPan LuqiPan added the bug Something isn't working label Mar 20, 2024
@LuqiPan LuqiPan added enhancement New feature or request and removed bug Something isn't working labels Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants