Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orchestration: allow developers to send custom tx messages #10345

Closed
0xpatrickdev opened this issue Oct 28, 2024 · 0 comments · Fixed by #10341
Closed

Orchestration: allow developers to send custom tx messages #10345

0xpatrickdev opened this issue Oct 28, 2024 · 0 comments · Fixed by #10341
Labels
enhancement New feature or request

Comments

@0xpatrickdev
Copy link
Member

What is the Problem Being Solved?

As an orchestration developer, I want to send a message that isn't yet supported by the Orchestration API. I know executeEncodedTx exists, but I don't have access to via the CosmosOrchestrationAccount exo.

Description of the Design

Add an executeEncodedTx method to CosmosOrchestrationAccount that calls into IcaAccount.executeEncodedTx

Security Considerations

Message allowlists are controlled by the host chain, not the controller chain. If a developer attempts to send a message that isn't supported by a host they will receive an error. Exposing this shouldn't create security issues.

Scaling Considerations

This change will allow developers to extend the Orch API without needing changes in @agoric/orchestration for each new message type.

Test Plan

There is existing coverage of executeEncodedTx in bootstrap tests. A simple unit test for cosmos-orchestration-account should be sufficient here.

Upgrade Considerations

This change will be part of library code slated for an NPM orch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant