Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test slog senders in a3p #10365

Open
mhofman opened this issue Oct 30, 2024 · 1 comment
Open

Test slog senders in a3p #10365

mhofman opened this issue Oct 30, 2024 · 1 comment
Labels
enhancement New feature or request telemetry tooling repo-wide infrastructure

Comments

@mhofman
Copy link
Member

mhofman commented Oct 30, 2024

What is the Problem Being Solved?

In the past we're encountered issues with slog senders failing on some input (unknown or untested). Most recently #9569 / #8272.

While the slogfile, otel-trace and flight recorder are tested in the "deployment" integration test, that doesn't sufficiently cover all the possible slog events generated by a real chain (e.g. no smart wallet, no upgrade).

We should test the slog senders in a more realistic environment, such as a3p.

Description of the Design

Enable the different otel slog senders in a3p using environment variables, and SLOGSENDER_AGENT=process.

Enable failure of the chain process on slog sender failure.

Avoid leaving telemetry data in the final slog image somehow.

Security Considerations

None

Scaling Considerations

Slog processing can slowdown resource constrained systems like the CI runners

Test Plan

Somehow verify that slog senders are being used.

Upgrade Considerations

None, testing infra only

@mhofman mhofman added enhancement New feature or request tooling repo-wide infrastructure telemetry labels Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request telemetry tooling repo-wide infrastructure
Projects
None yet
Development

No branches or pull requests

2 participants
@mhofman and others