Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

liveslots may override vpid in eventual send handler #10777

Open
mhofman opened this issue Dec 26, 2024 · 0 comments
Open

liveslots may override vpid in eventual send handler #10777

mhofman opened this issue Dec 26, 2024 · 0 comments
Assignees
Labels
bug Something isn't working liveslots requires vat-upgrade to deploy changes

Comments

@mhofman
Copy link
Member

mhofman commented Dec 26, 2024

Describe the bug

While investigating solutions for #10757, and how liveslots and the virtual reference manager handling of promises interacts, we realized that if an eventual send promise is added to virtual data before the liveslots handler for the eventual send is invoked in the next turn, then the handler will unconditionally allocate a vpid for the promise, overriding the one that would have been created when marshalling the promise in vdata.

To Reproduce

const p = E(foo).bar();
virtualSet.add(p); // allocates vpid for vdata serialization
await null; // liveslots handler unconditionally allocates new vpid

Expected behavior

The vpid allocated by vdata should be used by liveslots

@mhofman mhofman added bug Something isn't working liveslots requires vat-upgrade to deploy changes labels Dec 26, 2024
@mhofman mhofman self-assigned this Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working liveslots requires vat-upgrade to deploy changes
Projects
None yet
Development

No branches or pull requests

1 participant