Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(After ConstantProduct AMM) add ParamGovernance to ConstantProduct AMM #3862

Closed
Chris-Hibbert opened this issue Sep 21, 2021 · 0 comments · Fixed by #4006
Closed

(After ConstantProduct AMM) add ParamGovernance to ConstantProduct AMM #3862

Chris-Hibbert opened this issue Sep 21, 2021 · 0 comments · Fixed by #4006
Assignees
@Chris-Hibbert
Labels
AMM Core Economy OBSOLETE in favor of INTER-protocol enhancement New feature or request Governance Governance

Comments

@Chris-Hibbert
Copy link
Contributor

What is the Problem Being Solved?

The ConstantProduct AMM (#3771, #3791) was added in parallel to the governance framework (#3448, 3189). It needs to be updated to include governance functionality

Description of the Design

The AMM's parameters should be visibly under the control of Governance.

Security Considerations

Requires serious security review

Test Plan

ensure governed params are visible.
@Chris-Hibbert Chris-Hibbert added the enhancement New feature or request label Sep 21, 2021
@Chris-Hibbert Chris-Hibbert mentioned this issue Sep 21, 2021
Closed
26 tasks
@Chris-Hibbert Chris-Hibbert added AMM Beta Core Economy OBSOLETE in favor of INTER-protocol Governance Governance labels Sep 21, 2021
@Chris-Hibbert Chris-Hibbert added this to the Beta Phase 4: Governance milestone Sep 21, 2021
@Chris-Hibbert Chris-Hibbert self-assigned this Sep 21, 2021
This was referenced Oct 26, 2021
Merged
Merged
@mergify mergify bot closed this as completed in #4006 Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Chris-Hibbert Chris-Hibbert

Labels
AMM Core Economy OBSOLETE in favor of INTER-protocol enhancement New feature or request Governance Governance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Governance to the constantProduct AMM Agoric/agoric-sdk
1 participant
@Chris-Hibbert