Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agoricNames: managing naming consistency between dApps and chain #4084

Open
dckc opened this issue Nov 16, 2021 · 2 comments
Open

agoricNames: managing naming consistency between dApps and chain #4084

dckc opened this issue Nov 16, 2021 · 2 comments
Assignees
Labels
code-style defensive correctness patterns; readability thru consistency Dapp & UI Support enhancement New feature or request

Comments

@dckc
Copy link
Member

dckc commented Nov 16, 2021

What is the Problem Being Solved?

In #4026, we're renaming 'autoswap' to 'amm' in agoricNames in the treasury package. The code uses plain string literals, which suggests it's an arbitrary choice, but it's actually constrained by expectations from the dApp front-end.

Description of the Design

Perhaps factor out the string constants into a new package?

The java ecosystem seems to use API jar files for this sort of thing:

Or perhaps triangulate via documentation?

Security Considerations

I can't think of any.

Test Plan

Existing tests are likely to establish that this is working.

cc @Chris-Hibbert @michaelfig

@dckc dckc added enhancement New feature or request Dapp & UI Support code-style defensive correctness patterns; readability thru consistency labels Nov 16, 2021
@Tartuffo
Copy link
Contributor

Tartuffo commented Feb 9, 2022

@dckc Can you please put an estimate on this one?

@dckc
Copy link
Member Author

dckc commented Feb 9, 2022

I estimate 1 to triangulate via documentation (which @dtribble made supportive noises about).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-style defensive correctness patterns; readability thru consistency Dapp & UI Support enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants