Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liens can only be taken on vested tokens #4332

Closed
JimLarson opened this issue Jan 20, 2022 · 0 comments
Closed

Liens can only be taken on vested tokens #4332

JimLarson opened this issue Jan 20, 2022 · 0 comments
Assignees
Labels
bug Something isn't working duplicate Inter-protocol Overarching Inter Protocol
Milestone

Comments

@JimLarson
Copy link
Contributor

What is the Problem Being Solved?

We want to disallow the use of unvested tokens for obtaining a lien, since a clawback would remove the collateral and eliminate the incentive to repay the loan.

Description of the Design

  • Add a field for unvested tokens to the GET_ACCOUNT_STATE bridge query (Cosmos)
  • Use it when advertising how git a lien you can take (JS)
  • Check vested token supply when increasing a lien in x/lien (Cosmos).

Security Considerations

None

Test Plan

Unit tests on each side.

@JimLarson JimLarson added the enhancement New feature or request label Jan 20, 2022
@JimLarson JimLarson self-assigned this Jan 20, 2022
@JimLarson JimLarson added getRUN Inter-protocol Overarching Inter Protocol labels Jan 21, 2022
@Tartuffo Tartuffo removed the MN-1 label Feb 7, 2022
@Tartuffo Tartuffo added bug Something isn't working and removed enhancement New feature or request labels Feb 16, 2022
@Tartuffo Tartuffo added this to the Mainnet 1 milestone Mar 23, 2022
@dckc dckc added the duplicate label Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate Inter-protocol Overarching Inter Protocol
Projects
None yet
Development

No branches or pull requests

3 participants