Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert voteCounters in governParam.js to a WeakStore #4340

Open
Chris-Hibbert opened this issue Jan 21, 2022 · 0 comments
Open

Convert voteCounters in governParam.js to a WeakStore #4340

Chris-Hibbert opened this issue Jan 21, 2022 · 0 comments
Assignees
@Chris-Hibbert
Labels
Governance Governance performance Performance related issues resource-exhaustion Threats to availability from resource exhaustion attacks technical-debt

Comments

@Chris-Hibbert
Copy link
Contributor

What is the Problem Being Solved?

All persistent state in contract code should be in one of our Stores. governParams.js currently uses a WeakSet in one place. It should be converted to a WeakStore before the Purple Team exercise.

Description of the Design

Straight conversion.

Security Considerations

This adds robustness by supporting unlimited growth of the collection.

Test Plan

Existing tests are sufficient.
@Chris-Hibbert Chris-Hibbert added performance Performance related issues Small code-style defensive correctness patterns; readability thru consistency technical-debt Governance Governance resource-exhaustion Threats to availability from resource exhaustion attacks labels Jan 21, 2022
@Chris-Hibbert Chris-Hibbert self-assigned this Jan 21, 2022
@Tartuffo Tartuffo added MN-1 and removed MN-1 labels Jan 21, 2022
@Tartuffo Tartuffo removed the MN-1 label Feb 7, 2022
@Tartuffo Tartuffo added this to the Mainnet 1 milestone Mar 23, 2022
@Tartuffo Tartuffo removed the Small label Apr 8, 2022
@turadg turadg removed the code-style defensive correctness patterns; readability thru consistency label Jun 30, 2022
@Chris-Hibbert Chris-Hibbert removed this from the Mainnet 1 milestone Jul 12, 2022
@Chris-Hibbert Chris-Hibbert mentioned this issue Aug 7, 2023
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Chris-Hibbert Chris-Hibbert

Labels
Governance Governance performance Performance related issues resource-exhaustion Threats to availability from resource exhaustion attacks technical-debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@turadg @Tartuffo @Chris-Hibbert