Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect to Kelpr from Wallet UI #4421

Closed
samsiegart opened this issue Jan 31, 2022 · 2 comments
Closed

Connect to Kelpr from Wallet UI #4421

samsiegart opened this issue Jan 31, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request UI wallet
Milestone

Comments

@samsiegart
Copy link
Contributor

What is the Problem Being Solved?

For the on-chain wallet, requests will go through Keplr rather than ag-solo. We need to add functionality for the wallet frontend to connect to the Agoric chain through the extension.

Description of the Design

A dropdown menu/button in the appbar for connecting to Keplr should be added. From the dropdown, users can select the network (devnet, local, mainnet etc.) or add another. Then, the UI will connect or suggest the chain to Keplr. For now we should just get the connection working, but eventually we'll have to make the wallet actions work properly through Keplr txns.

Notes:
CosmJS: https://docs.keplr.app/api/cosmjs.html#example
Custom txn types: https://github.com/Agoric/faucet/blob/cosmjs-rpc/src/gift.js
Local chain network-config.json:

{
  "chainName": "agoric",
  "peers": [
  ],
  "rpcAddrs": [
    "127.0.0.1:26657"
  ],
  "seeds": [
  ]
}

Security Considerations

Test Plan

@dckc
Copy link
Member

dckc commented May 12, 2022

Is there some trick to get this to work? I see a Connect to Wallet button in screenshots in PR #4430 but not in my running wallet UI.

@samsiegart
Copy link
Contributor Author

Is there some trick to get this to work? I see a Connect to Wallet button in screenshots in PR #4430 but not in my running wallet UI.

Yes, the trick is ?onchain=true in the URL. After you connect you can go as far as seeing window.cosmJS in your console, but nothing in the UI actually works on-chain yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request UI wallet
Projects
None yet
Development

No branches or pull requests

3 participants