Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

walletFactory uses virtual objects #4489

Closed
michaelfig opened this issue Feb 7, 2022 · 4 comments · Fixed by #6165
Closed

walletFactory uses virtual objects #4489

michaelfig opened this issue Feb 7, 2022 · 4 comments · Fixed by #6165
Assignees
Labels
enhancement New feature or request wallet
Milestone

Comments

@michaelfig
Copy link
Member

What is the Problem Being Solved?

Wallet manager and individual wallet backends need to be scalable.

Description of the Design

Do the wholesale migration of the wallet backends to collections of virtual objects.

Security Considerations

Test Plan

@michaelfig michaelfig added enhancement New feature or request wallet labels Feb 7, 2022
@Tartuffo
Copy link
Contributor

@michaelfig Do you want this to be under the #3995 (as it is currently) or #4511 (which is the epic for all of the other virtual objects / collection work)?

@Tartuffo Tartuffo added this to the Mainnet 1 milestone Mar 23, 2022
@michaelfig michaelfig changed the title Multitenant wallet manager uses virtual objects Multitenant smart wallet manager uses virtual objects Jun 3, 2022
@Tartuffo
Copy link
Contributor

This work might get subsumed fully or partially by #4484, or at least much lest work.

@Tartuffo
Copy link
Contributor

Wallet Manager is deprecated, so do we still need to do this?

@turadg turadg changed the title Multitenant smart wallet manager uses virtual objects Multitenant smart wallet manager uses durable Aug 4, 2022
@turadg turadg changed the title Multitenant smart wallet manager uses durable Multitenant smart wallet manager uses virtual objects Aug 4, 2022
@warner
Copy link
Member

warner commented Aug 24, 2022

We need to measure the slope: RAM used per provisioned account, and also GC time (because that scales with the size of the object graph, hence RAM). Then we can compare that against the 2GiB per-vat limit (#5953) to estimate how many users can be added before the worker would be killed by the memory limit, and then since it is (supposed to be) a criticalVat, the kernel panics and the chain halts.

@dckc dckc changed the title Multitenant smart wallet manager uses virtual objects walletFactory uses virtual objects Sep 1, 2022
This was referenced Sep 7, 2022
@mergify mergify bot closed this as completed in #6165 Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wallet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants