Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allocateExportID needs to keep a persistent record of its counter #4855

Closed
FUDCo opened this issue Mar 16, 2022 · 1 comment
Closed

allocateExportID needs to keep a persistent record of its counter #4855

FUDCo opened this issue Mar 16, 2022 · 1 comment
Assignees
@FUDCo
Labels
bug Something isn't working
Milestone
Mainnet 1 RC0

Comments

@FUDCo
Copy link
Contributor

FUDCo commented Mar 16, 2022

The allocateExportID function (in liveslots and deviceslots) uses a RAM-based counter to allocate identifiers. This works fine in the world of orthogonal persistence but will result in various kinds of things going wrong when memory state is lost during upgrade. It needs to maintain the counter in persistent storage.
@FUDCo FUDCo added the bug Something isn't working label Mar 16, 2022
@FUDCo FUDCo self-assigned this Mar 16, 2022
@FUDCo FUDCo mentioned this issue Mar 16, 2022
Merged
@FUDCo
Copy link
Contributor Author

FUDCo commented Mar 16, 2022

Duplicate of #4730

@FUDCo FUDCo marked this as a duplicate of #4730 Mar 16, 2022
@FUDCo FUDCo closed this as completed Mar 16, 2022
@Tartuffo Tartuffo added this to the Mainnet 1 milestone Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FUDCo FUDCo

Labels
bug Something isn't working
Projects
None yet
Milestone
Mainnet 1 RC0
Development

No branches or pull requests
2 participants
@Tartuffo @FUDCo