Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"yarn lint" succeeds even when vscode correctly shows lint errors #5416

Closed
erights opened this issue May 21, 2022 · 3 comments
Closed

"yarn lint" succeeds even when vscode correctly shows lint errors #5416

erights opened this issue May 21, 2022 · 3 comments
Assignees
Labels
bug Something isn't working duplicate

Comments

@erights
Copy link
Member

erights commented May 21, 2022

image

The hover in the left pane above correctly shows that vatParams is an unused parameter (and therefore should be spelled _vatParams). The right pane shows that when we ran yarn lint in the same directory, it did not complain. Similarly, running yarn lint at the top of agoric-sdk does not complain about this.

@erights erights added the bug Something isn't working label May 21, 2022
@erights
Copy link
Member Author

erights commented May 21, 2022

@michaelfig @turadg I'm guessing when I assigned this to y'all. Please reassign to whoever is appropriate. Thanks.

@erights
Copy link
Member Author

erights commented May 21, 2022

image

Just another example. This one showing two errors on the left, neither of which is reported on the right. The non-report of the // @ts-expect-error is especially unfortunate, since that's why we switched to it from // @ts-ignore-error in the first place.

@turadg
Copy link
Member

turadg commented May 21, 2022

Known issue, the solution for which is a big amount of work explicitly deprioritized to after MN-1.

@turadg turadg closed this as completed May 21, 2022
@dckc dckc added the duplicate label May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate
Projects
None yet
Development

No branches or pull requests

4 participants