Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Browser compatibility of Launch DApps #5583

Closed
Tartuffo opened this issue Jun 13, 2022 · 8 comments
Closed

Document Browser compatibility of Launch DApps #5583

Tartuffo opened this issue Jun 13, 2022 · 8 comments
Assignees
Labels
documentation Improvements or additions to documentation UI vaults_triage DO NOT USE

Comments

@Tartuffo
Copy link
Contributor

Tartuffo commented Jun 13, 2022

At Launch, unless we implement a different Wallet Connect protocol (#5506), we will only support Firefox and Chromium-based browsers. We should clearly document that on our website, along with any necessary configuration settings such disabling Shields Up in Brave.

If feasible, we should also detect when a Chromium browser has settings that preclude the DAPpps from running correctly, e.g. Brave with Shields Up.

@Tartuffo Tartuffo added UI documentation Improvements or additions to documentation labels Jun 13, 2022
@Tartuffo Tartuffo added this to the Mainnet 1 milestone Jul 19, 2022
@Tartuffo Tartuffo removed this from the Mainnet 1 RC0 milestone Aug 10, 2022
@otoole-brendan
Copy link
Contributor

I've included a note at top of PSM page that notifies users to turn off their Brave shields before continuing with PSM dapp

@dckc
Copy link
Member

dckc commented Oct 28, 2022

I just got a problem report from a colleague:

when i press Connect Kepler (after accepting terms) nothing seems to happen. iphone firefox.

I didn't realize there was such a thing as keplr for firefox, let alone for iphone. But there is: https://addons.mozilla.org/en-US/firefox/addon/keplr/

@otoole-brendan do we document supported browsers in https://docs.inter.trade/ ? I'm struggling to find it.

@turadg
Copy link
Member

turadg commented Oct 28, 2022

@otoole-brendan
Copy link
Contributor

Re-prioritizing this for Vaults release - we need to be able to say what browsers we support.

@otoole-brendan otoole-brendan removed this from the Vaults EVP milestone Apr 27, 2023
@ivanlei ivanlei added this to the Vaults Validation milestone Apr 28, 2023
@turadg
Copy link
Member

turadg commented Jun 6, 2023

Once this is done we need to QA the dapps on each browser and common configurations. For example, Brave with Shields or Firefox with Tracking Prevention. Whatever diagnostic signals we use will have to be robust to browser changes, such as Chrome's First-Party Sets rollout that broke the wallet bridge: Agoric/dapp-psm#69

@otoole-brendan
Copy link
Contributor

I have documented supported browsers on Gitbook: https://docs.inter.trade/user-how-to/supported-browsers

@otoole-brendan
Copy link
Contributor

I'd like to do a bit more testing on Firefox before closing ticket though.
@turadg I see diagnostic signals/tools for UX being a separate issue (I'm happy to raise). I'd like to continue the discussion to know more about what's possible on that front though - will take it to Slack or use new issue.

@otoole-brendan
Copy link
Contributor

Docs updated. Closing for now - Edge testing required to change - not subject to this ticket - will create another if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation UI vaults_triage DO NOT USE
Projects
None yet
Development

No branches or pull requests

6 participants