Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use .eslintrc.json/.cjs rather than .eslintrc.js #565

Closed
30 tasks
warner opened this issue Feb 18, 2020 · 2 comments
Closed
30 tasks

use .eslintrc.json/.cjs rather than .eslintrc.js #565

warner opened this issue Feb 18, 2020 · 2 comments
Labels
tooling repo-wide infrastructure

Comments

@warner
Copy link
Member

warner commented Feb 18, 2020

To support #527, we need to make sure all our .js files are ES6-module format (with import and export), rather than CommonJS format (with require and exports.foo= and module.exports=). This includes the config files we use for ESLint, which so far have been CommonJS format.

The task is to rewrite them into JSON, and rename them to .json instead of .js. I'm pretty sure this includes our new .eslintrc-jessie.js files, but I'm not entirely sure how those get composed or loaded.

  • acorn-eventual-send
  • agoric-cli
  • assert
  • autoswap-frontend
  • bundle-source
  • captp
  • cosmic-swingset
  • default-evaluate-options
  • deployment
  • ERTP
  • evaluate
  • eventual-send
  • import-manager
  • make-promise
  • marshal
  • pixel-demo
  • registrar
  • same-structure
  • sharing-service
  • sparse-ints
  • spawner
  • store
  • SwingSet
  • swingset-runner
  • tame-metering
  • transform-eventual-send
  • transform-metering
  • wallet-frontend
  • weak-store
  • zoe
@warner
Copy link
Member Author

warner commented Feb 19, 2020

@michaelfig pointed out that we can just rename the files to .eslintrc.cjs instead, and keep using the CommonJS syntax. Also that our Jessie linting will require more than the JSON-based configuration.

@warner warner changed the title use .eslintrc.json rather than .eslintrc.js use .eslintrc.json/.cjs rather than .eslintrc.js Feb 19, 2020
@warner warner added the tooling repo-wide infrastructure label Feb 19, 2020
@katelynsills
Copy link
Contributor

Can we close this? I couldn't find any eslintrc.js files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling repo-wide infrastructure
Projects
None yet
Development

No branches or pull requests

2 participants