Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add storage for makePublishKit #5739

Closed
turadg opened this issue Jul 8, 2022 · 0 comments · Fixed by #5766
Closed

add storage for makePublishKit #5739

turadg opened this issue Jul 8, 2022 · 0 comments · Fixed by #5766
Assignees
Labels
enhancement New feature or request wallet
Milestone

Comments

@turadg
Copy link
Member

turadg commented Jul 8, 2022

What is the Problem Being Solved?

We have makePublishKit but need something that stores data off-chain. Once we have that then #5386 can return itssubscriber instead of a Notifier. Consumers that need a Notifier can pass that to makeNotifierFromSubscriber from #5737.

Description of the Design

The storageNode and marshaller arguments are generally optional so we can continue that in this case. Since they are optional we can add them to the params of makePublishKit to optionally tee to storage.

Alternately we could have makeStoredPublishKit.

Security Considerations

Will tee storage to storageNode. marshaller is powerful.

Test Plan

Tests with storage and tests integrating with makeNotifierFromSubscriber.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wallet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants