Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vat-vattp deliverInbound methods should not silently create a mailbox #5824

Open
gibson042 opened this issue Jul 25, 2022 · 1 comment
Open
Labels
bug Something isn't working SwingSet package: SwingSet vaults_triage DO NOT USE

Comments

@gibson042
Copy link
Member

Describe the bug

vat-vattp deliverInboundMessages and deliverInboundAck methods currently rely upon getRemote, which implements the "provider" pattern in which the requested object is initialized if it does not already exist. This is incorrect, as pointed out in https://github.com/Agoric/agoric-sdk/pull/5781/files#r925070254 . But attempting to correct it within that pull request broke some tests, so we'll need to fix them as well.

Expected behavior

deliverInboundMessages and deliverInboundAck should throw an exception when passed a name that does not identify a mailbox previously created by addRemote.

@gibson042 gibson042 added bug Something isn't working SwingSet package: SwingSet labels Jul 25, 2022
@Tartuffo Tartuffo added this to the Mainnet 1 RC0 milestone Aug 17, 2022
@warner
Copy link
Member

warner commented Aug 19, 2022

I'd love to have this soon, but I think the pso milestone doesn't strictly require it, if the "provisionpass" limitation prevents arbitrary addresses from getting messages into the mailbox device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working SwingSet package: SwingSet vaults_triage DO NOT USE
Projects
None yet
Development

No branches or pull requests

4 participants