Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop generic getters in paramManager #6138

Open
Chris-Hibbert opened this issue Sep 5, 2022 · 0 comments · May be fixed by #8157
Open

drop generic getters in paramManager #6138

Chris-Hibbert opened this issue Sep 5, 2022 · 0 comments · May be fixed by #8157
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers Governance Governance

Comments

@Chris-Hibbert
Copy link
Contributor

What is the Problem Being Solved?

paramManager has support for getting parameter values directly by name, and indirectly by type. The former is superior, and the latter should be dropped.

For instance, the AMM supports both E(amm.ammPublicFacet).getProtocolFee(); and E(amm.ammPublicFacet).getNat('ProtocolFee');. The former's type is known via typescript.

Description of the Design

Drop the generic methods. This will simplify a few interfaces.

Security Considerations

Just usability.

Test Plan

Unneeded.

@Chris-Hibbert Chris-Hibbert added enhancement New feature or request good first issue Good for newcomers Governance Governance labels Sep 5, 2022
@Chris-Hibbert Chris-Hibbert added this to the Mainnet 1 RC0 milestone Sep 5, 2022
@Chris-Hibbert Chris-Hibbert self-assigned this Sep 5, 2022
@Tartuffo Tartuffo removed this from the Mainnet 1 RC0 milestone Sep 5, 2022
@Chris-Hibbert Chris-Hibbert linked a pull request Aug 7, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers Governance Governance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants