Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

verify priceAggregatorChainlink.js is production-ready #6571

Closed
4 of 5 tasks
Tracked by #6644
michaelfig opened this issue Nov 15, 2022 · 1 comment
Closed
4 of 5 tasks
Tracked by #6644

verify priceAggregatorChainlink.js is production-ready #6571

michaelfig opened this issue Nov 15, 2022 · 1 comment
Assignees
@turadg
Labels
enhancement New feature or request oracle Related to on-chain oracles. vaults_triage DO NOT USE
Milestone
Vaults EVP

Comments

@michaelfig
Copy link
Member

michaelfig commented Nov 15, 2022 •
edited by turadg
Loading

What is the Problem Being Solved?

refs: #5791

The priceAggregatorChainlink.js contract is not yet ready for production, due to some neglect and missing features. It should be upgraded, then used by the oracle network instead of priceAggregator.js.

Description of the Design

Security Considerations

Test Plan

For the canonical priceAggregator contract…
@michaelfig michaelfig added enhancement New feature or request oracle Related to on-chain oracles. next-release labels Nov 15, 2022
@turadg turadg self-assigned this Nov 30, 2022
This was referenced Dec 2, 2022
Merged
Closed
@rowgraus rowgraus added the vaults_triage DO NOT USE label Dec 20, 2022
@turadg turadg changed the title Revitalise priceAggregatorChainlink.js verify priceAggregatorChainlink.js is production-ready Dec 21, 2022
This was referenced Dec 21, 2022
Merged
Closed
Merged
Merged
@turadg turadg mentioned this issue Jan 3, 2023
Merged
@dckc dckc mentioned this issue Jan 26, 2023
Closed
@ivanlei ivanlei added this to the Vaults RC0 milestone Feb 1, 2023
@turadg
Copy link
Member

turadg commented Apr 20, 2023

Done enough for release. The tech debt of TODOs and legacy calls are acceptable tech debt. The only FIXME are types.

@turadg turadg closed this as completed Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turadg turadg

Labels
enhancement New feature or request oracle Related to on-chain oracles. vaults_triage DO NOT USE
Projects
None yet
Milestone
Vaults EVP
Development

When branches are created from issues, their pull requests are automatically linked.

6571-chainlink Agoric/agoric-sdk
5 participants
@turadg @michaelfig @Tartuffo @ivanlei @rowgraus