Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

offer exit ability through smart wallet bridge #6906

Closed
turadg opened this issue Feb 1, 2023 · 2 comments · Fixed by #7028
Closed

offer exit ability through smart wallet bridge #6906

turadg opened this issue Feb 1, 2023 · 2 comments · Fixed by #7028
Assignees
Labels
enhancement New feature or request vaults_triage DO NOT USE wallet
Milestone

Comments

@turadg
Copy link
Member

turadg commented Feb 1, 2023

What is the Problem Being Solved?

An offer may take longer to satisfy than the user can tolerate. Currently a vault opening or balance adjustment waits for the latest price from an oracle and if oracles are paused then the offer resolution would also be paused.

While an offer is in flight, the user's funds are escrowed by Zoe. So the problem is that users don't have access to their wants or their gives.

Description of the Design

Make the smart wallet take an exitOffer message that calls tryExit on the seat of an earlier executeOffer.

Security Considerations

Scaling Considerations

Test Plan

@erights
Copy link
Member

erights commented Feb 17, 2023

Exiting an offer is essential for ERTP.

I think you mean "essential for Zoe". ERTP has no idea what an offer is or what exiting one would mean.

@turadg turadg self-assigned this Feb 17, 2023
@samsiegart samsiegart self-assigned this Feb 21, 2023
@samsiegart
Copy link
Contributor

Discussed with @turadg- we'll revisit this after #6992 lands to see if there's any multi-turn offers in the implementation. Otherwise this is not worth implementing for EVP.

@mergify mergify bot closed this as completed in #7028 Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vaults_triage DO NOT USE wallet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants