Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smart wallet fails on 2nd payment from unknown brand #6961

Closed
dckc opened this issue Feb 9, 2023 · 0 comments · Fixed by #7027
Closed

smart wallet fails on 2nd payment from unknown brand #6961

dckc opened this issue Feb 9, 2023 · 0 comments · Fixed by #7027
Assignees
Labels
bug Something isn't working wallet
Milestone

Comments

@dckc
Copy link
Member

dckc commented Feb 9, 2023

Describe the bug

Payments bearing unknown brands are supposed to be queued until the corresponding issuer is added. In the queue implementation, an array is hardened and then we later .push() to it, which throws.

To Reproduce

Run this test:

test.failing('deposit > 1 payment to unknown brand', async t => {

Expected behavior

doesn't throw. Payment is deposited when the issuer comes along

Additional context

Unknown brands are only possible in MN-2 / MN-3 / devnet.

cc @turadg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wallet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants