Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove the AMM #7055

Closed
Chris-Hibbert opened this issue Feb 23, 2023 · 0 comments · Fixed by #7074
Closed

remove the AMM #7055

Chris-Hibbert opened this issue Feb 23, 2023 · 0 comments · Fixed by #7074
Assignees
@Chris-Hibbert
Labels
enhancement New feature or request hygiene Tidying up around the house Inter-protocol Overarching Inter Protocol vaults_triage DO NOT USE Vaults VaultFactor (née Treasury)
Milestone
Vaults EVP

Comments

@Chris-Hibbert
Copy link
Contributor

What is the Problem Being Solved?

The AMM is entangled with VaultFactory and the Reserve in bootstrap, which is making it hard to make a clean PR that switches the Vaults to use an Auction for liquidation.

Description of the Design

Remove the AMM code, and references to it in bootstrap. leave the VaultFactory depending on the liquidation contract, which doesn't explicitly depend on the AMM. There may be tests that don't pass. If so, suppress them, with the intention of reinstating them or replacing them in the auction (#7000) /vault (#7047) PRs.

Security Considerations

Insignificant. it's about removing code that isn't used in PSM or vaults releases.

Scaling Considerations

removing code makes things better.

Test Plan

remove tests. suppress (test.skip) tests that don't pass.
@Chris-Hibbert Chris-Hibbert added enhancement New feature or request hygiene Tidying up around the house Inter-protocol Overarching Inter Protocol Vaults VaultFactor (née Treasury) MUST-HAVE labels Feb 23, 2023
@Chris-Hibbert Chris-Hibbert self-assigned this Feb 23, 2023
This was referenced Feb 24, 2023
Closed
Merged
@ivanlei ivanlei added the vaults_triage DO NOT USE label Feb 27, 2023
@ivanlei ivanlei added this to the Vaults EVP milestone Feb 27, 2023
@mergify mergify bot closed this as completed in #7074 Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Chris-Hibbert Chris-Hibbert

Labels
enhancement New feature or request hygiene Tidying up around the house Inter-protocol Overarching Inter Protocol vaults_triage DO NOT USE Vaults VaultFactor (née Treasury)
Projects
None yet
Milestone
Vaults EVP
Development

Successfully merging a pull request may close this issue.

feat(AMM)!: remove the AMM and cleanup bootstrap etc. dependencies Agoric/agoric-sdk
2 participants
@ivanlei @Chris-Hibbert