Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal to execute Vaults null upgrade in test nets #7562

Closed
3 of 4 tasks
Tracked by #7491
turadg opened this issue Apr 30, 2023 · 2 comments · Fixed by #7698
Closed
3 of 4 tasks
Tracked by #7491

proposal to execute Vaults null upgrade in test nets #7562

turadg opened this issue Apr 30, 2023 · 2 comments · Fixed by #7698
Assignees
Labels

Comments

@turadg
Copy link
Member

turadg commented Apr 30, 2023

What is the Problem Being Solved?

#7491 gives us confidence in the bulldozer upgrade from Pismo to Vaults.

When we've upgraded to Vaults we never want to have to bulldoze again. To have confidence in that we need to also perform upgrades of the Vaults release state.

Description of the Design

Tasks

Preview Give feedback
  1. Epic Inter-protocol vaults_triage
    turadg
  2. 10 of 10
    Epic Governance Inter-protocol contract-upgrade cosmic-swingset enhancement needs-design vaults_triage
    ivanlei
  3. force:integration
    mhofman

Use https://github.com/Agoric/docker-upgrade-test/tree/main/upgrade-test-scripts to make a new upgrade handler.
It includes gov1,gov2,gov3 accounts.
Use agoric and agops CLI commands in the scripts, as an end user could. Maybe adapt https://github.com/Agoric/agoric-sdk/blob/master/packages/agoric-cli/test/agops-vaults-smoketest.sh

Consider adapting the bootstrapTests which specify behavior and expected results.

After bulldozer we have three different kind of upgrades:

  1. Chain software (including SwingSet kernel, but doesn't change the contracts)
  2. Liveslots (e.g. xsnap, more complicated)
  • upgrade-by-replacement the contracts we've decided not to make durable
  • we have documentation of this but won't fully test before release
  1. Contracts (with CORE_EVAL)

This PR is about level 3. Figure out agd command to create the proposal. Call the Docker test harness's function to wait for it to complete.

Some vats we've decided will be upgrade by replacement. TBD whether to perform that replacement in this test.

Security Considerations

n/a

Scaling Considerations

n/a

Test Plan

What doesn't need to endure in Vaults release:

  • invitations (one exception is coveredCall but that's not part of production)
@turadg turadg added the enhancement New feature or request label Apr 30, 2023
@turadg turadg added this to the Vaults Validation milestone Apr 30, 2023
@turadg turadg added Testnet and removed enhancement New feature or request labels Apr 30, 2023
@ivanlei ivanlei added the vaults_triage DO NOT USE label May 1, 2023
@dckc
Copy link
Member

dckc commented May 1, 2023

Is this a dup of #6099? perhaps not... perhaps that one is an end-to-end test of one contract, where this one is less end-to-end but covers all vats/contracts

@turadg
Copy link
Member Author

turadg commented May 1, 2023

Exactly. 6099 is that a contract can be upgraded on a running chain. That can be a local chain. Ideally it would be in CI.

This is to do the real deal on testnet, after a bulldoze.

@turadg turadg self-assigned this May 8, 2023
@turadg turadg changed the title execute Vaults null upgrade in test nets proposal to execute Vaults null upgrade in test nets May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants