Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable cleanup old swingset state on bulldozer #7591

Closed
mhofman opened this issue May 3, 2023 · 1 comment · Fixed by #7606
Closed

Enable cleanup old swingset state on bulldozer #7591

mhofman opened this issue May 3, 2023 · 1 comment · Fixed by #7606
Assignees
Labels
cosmic-swingset package: cosmic-swingset enhancement New feature or request vaults_triage DO NOT USE
Milestone

Comments

@mhofman
Copy link
Member

mhofman commented May 3, 2023

What is the Problem Being Solved?

The upcoming vaults release performs a bulldozer upgrade (#6644), which uses a sqlite DB for the whole swingstore instead of the previous combination of LMDB, sqlite and plain files.

When upgrading the new swingstore will simply create the new file backing its DB and go along merrily. However the former files backing the old swingstore will stick around on the filesystem.

We should consider cleaning up the old swingstore state for housekeeping, or at least make it easier to cleanup in the future.

Description of the Design

  • Use a new path under which to store the new swingstore. @michaelfig proposed ${cosmosHome}/data/agoric
  • (optional) If that path does not exists, remove any ${cosmosHome}/data/ag-cosmos-chain-state

Security Considerations

Potentially removing some unexpected data

Scaling Considerations

None

Test Plan

Manual?

@mhofman mhofman added enhancement New feature or request cosmic-swingset package: cosmic-swingset labels May 3, 2023
@mhofman mhofman changed the title Cleanup old swingset state on bulldozer Enable cleanup old swingset state on bulldozer May 3, 2023
@michaelfig
Copy link
Member

I don't want the removal to be automatic. We have no idea what kind of precious files (copies of slogs for debugging problems, etc) validators might be storing in the old directory.

We should socialize to validators who have gone through the upgrade that they can free up disk space by manually deleting the old directory.

@ivanlei ivanlei added this to the Vaults EVP milestone May 4, 2023
@ivanlei ivanlei added the vaults_triage DO NOT USE label May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cosmic-swingset package: cosmic-swingset enhancement New feature or request vaults_triage DO NOT USE
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants