Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Vault Factory configurable with new Auctioneer contract #7954

Closed
1 task done
Tracked by #7159 ...
turadg opened this issue Jun 19, 2023 · 0 comments · Fixed by #9283
Closed
1 task done
Tracked by #7159 ...

make Vault Factory configurable with new Auctioneer contract #7954

turadg opened this issue Jun 19, 2023 · 0 comments · Fixed by #9283
Assignees

Comments

@turadg
Copy link
Member

turadg commented Jun 19, 2023

What is the Problem Being Solved?

auctioneer returns non-durable facets so we’ll need to give vaultFactory the new publicFacet after upgrade. That means we have to upgrade vaultFactory too, giving it a way to receive an auctioneer other than in its terms (because terms are only for initial start of a contract).

Description of the Design

The auctioneer is an implementation detail of the vaultFactory contract. Therefore it can go in privateArgs.

Move it from terms to privateArgs, so that it's set upon each start of the contract.

Security Considerations

Scaling Considerations

Test Plan

Blocked by

  1. Vaults bug
    Chris-Hibbert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants