Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revive zoe-full-upgrade test #8121

Closed
Tracked by #8291
Chris-Hibbert opened this issue Jul 31, 2023 · 4 comments
Closed
Tracked by #8291

revive zoe-full-upgrade test #8121

Chris-Hibbert opened this issue Jul 31, 2023 · 4 comments
Assignees
Labels
contract-upgrade deployment Chain deployment mechanism (e.g. testnet) enhancement New feature or request Zoe package: Zoe

Comments

@Chris-Hibbert
Copy link
Contributor

Chris-Hibbert commented Jul 31, 2023

What is the Problem Being Solved?

The zoe-full-upgrade test in deployment/upgrade-test/upgrade-test-scripts/agoric-upgrade-11/zoe-full-upgrade was bypassed because it was failing.

It should be re-instated once the new coreProposal ugrade handler is in place.

Description of the Design

An earlier version of the test included instructions on rebuilding the bundle and updating the hash. We should leave those instruction in until the test can depend on a git hash to select the version of source code it will be built from.

Security Considerations

Minor.

Scaling Considerations

None

Test Plan

This is about building a test that will continue to execute the same upgrade as was performed on-chain. It's hard to set that up as a stable test before the chain upgrade takes place.

Upgrade Considerations

The test is intended to convince us (ahead of time) and server as a regression test (after the fact) that the Zoe/ZCF upgrade will succeed.

@dckc
Copy link
Member

dckc commented Sep 1, 2023

@iomekam as I mentioned in an Aug 24 comment, in order for the upgrade core-eval to fit inside a chain upgrade, we need to use the agoric run / writeCoreProposal approach.

We were on that path earlier in #7969:

I'm about ready to take this on as part of #8291 (#8298). Should we assign this to me? Are you already started? Should we talk?

cc @turadg

@iomekam
Copy link
Contributor

iomekam commented Sep 1, 2023

Yes, I'm fine with assigning it to you. I'd love to have someone else utilize the new JS work, and I'm happy to pair on it as well if you run into any roadblocks.

@dckc
Copy link
Member

dckc commented Sep 1, 2023

well, #8291 is on the back burner now. So I'll leave this assigned to you.

But I did get this part more or less working. The relevant commits are:

here's hoping we find a little time to talk about them

@Chris-Hibbert
Copy link
Contributor Author

The is sufficiently tested in A3P now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contract-upgrade deployment Chain deployment mechanism (e.g. testnet) enhancement New feature or request Zoe package: Zoe
Projects
None yet
Development

No branches or pull requests

4 participants