Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getting-started CI test should actually track Getting Started docs #8381

Closed
mhofman opened this issue Sep 24, 2023 · 2 comments · Fixed by #8829
Closed

getting-started CI test should actually track Getting Started docs #8381

mhofman opened this issue Sep 24, 2023 · 2 comments · Fixed by #8829
Assignees
@LuqiPan
Labels
devex developer experience enhancement New feature or request tooling repo-wide infrastructure

Comments

@mhofman
Copy link
Member

mhofman commented Sep 24, 2023

What is the Problem Being Solved?

Some time ago, the docs site switched the Getting Started instructions from the fungible faucet dapp to the card store dapp, but our CI job didn't get the same update

Description of the Design

Replicate the actual docs, using dapp-card-store.
Also make sure that cd ui && yarn build works (it is currently broken with latest NPM, see #8379 and #8380)

Test Plan

CI that passes
@mhofman mhofman added enhancement New feature or request tooling repo-wide infrastructure labels Sep 24, 2023
@dckc dckc added the devex developer experience label Nov 1, 2023
@dckc
Copy link
Member

dckc commented Dec 27, 2023

dapp-offer-up replaces dapp-card-store as of...

@turadg turadg mentioned this issue Jan 8, 2024
Closed
@dckc
Copy link
Member

dckc commented Jan 11, 2024

@turadg noticed that gettingStartedWorkflowTest is failing in ci for #8638:

  - 'too many retries'
  + 'listening'

https://github.com/Agoric/agoric-sdk/actions/runs/7158926782/job/19491612341?pr=8638#step:8:2031

@LuqiPan LuqiPan mentioned this issue Jan 26, 2024
Merged
@ivanlei ivanlei mentioned this issue Feb 3, 2024
Closed
@dckc dckc mentioned this issue Feb 13, 2024
Merged
@mergify mergify bot closed this as completed in #8829 Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LuqiPan LuqiPan

Labels
devex developer experience enhancement New feature or request tooling repo-wide infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(integration-test): use dapp-offer-up as target for getting-start… Agoric/agoric-sdk
3 participants
@mhofman @dckc @LuqiPan