Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contract upgrade test of KREAd #8386

Closed
turadg opened this issue Sep 25, 2023 · 1 comment
Closed

contract upgrade test of KREAd #8386

turadg opened this issue Sep 25, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@turadg
Copy link
Member

turadg commented Sep 25, 2023

What is the Problem Being Solved?

#8329 is the Deployment test of #8280

We also need "Upgrade test" of the contract upgrading in place.

Description of the Design

We have several ways to test this:

  • swingset test
  • bootstrap test
  • chain test

Now that we have the deployment test, that's a high fidelity way to do the chain test. Let's do that.

https://github.com/Agoric/agoric-sdk/blob/master/packages/builders/scripts/vats/restart-vats.js#L24 shows how to write build a proposal that restarts all vats. we only need to restart contracts and specifically just two,

#8361 or a new branch off that is where the work should go #8361

From bootstrap space gather,

Security Considerations

Scaling Considerations

Test Plan

Upgrade Considerations

@turadg turadg added the enhancement New feature or request label Sep 25, 2023
@turadg
Copy link
Member Author

turadg commented Sep 26, 2023

Passing now with a manual edit to the KRead contract: renaming start to prepare to satisfy the Zoe in MN-u11.

When it comes time to actually upgrade, their updated contract can use prepare or if MN has #8045 then it can continue to use start.

There is more to do to make this kind of test parameterized but for now the requirement is satisfied: we have tested contract upgrade in a repeatable manner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants