Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert awaits in network and ibc vats to promise watcher #8867

Closed
2 tasks done
Tracked by #5696
iomekam opened this issue Feb 6, 2024 · 2 comments · Fixed by #8964
Closed
2 tasks done
Tracked by #5696

Convert awaits in network and ibc vats to promise watcher #8867

iomekam opened this issue Feb 6, 2024 · 2 comments · Fixed by #8964
Assignees
Labels
enhancement New feature or request needs-design

Comments

@iomekam
Copy link
Contributor

iomekam commented Feb 6, 2024

What is the Problem Being Solved?

We've been working on making the network and IBC vats durable (#8721). Leftover work from this initiative is that we haven't made promises durable yet, which prevents us from truly being able to upgrade.

Description of the Design

As part of the vow(whenable) work, we've created promise watchers that are durable and can ensure that a promise is reconnected on upgrade. We need to go through the two vats and migrate any code awaiting on a Vow to use a watcher insead

open design questions:

  • use the vow-capable E work-alike?
  • convert all awaits? or are there short-lived ones that should not be converted?

Security Considerations

Scaling Considerations

Test Plan

  • upgrade / restart the vats at many points in the state machine

Upgrade Considerations

Tasks

Preview Give feedback
  1. enhancement
    michaelfig
  2. enhancement
    michaelfig
@iomekam iomekam added the enhancement New feature or request label Feb 6, 2024
@dckc dckc self-assigned this Feb 13, 2024
@dckc
Copy link
Member

dckc commented Feb 14, 2024

Following the upgrade-at-each-point-in-a-flow test pattern, I'm trying to do some testing work to establish where the finish line is. I don't yet have a test failing in a way that shows that we're not already there. :-/

test-net-ibc-upgrade.ts currently a06db4c, based on #8721

net-ibc-test-log.md

cc @michaelfig @gibson042 @turadg

@dckc
Copy link
Member

dckc commented Feb 15, 2024

Richard found a failing test!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-design
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants