orchestration: vow interface guard consistency #9611
Labels
code-style
defensive correctness patterns; readability thru consistency
enhancement
New feature or request
What is the Problem Being Solved?
We use a mixture of
VowShape
andNetworkShape.Vow$
when defining interface guards for watchers in@agoric/orchestration
.VowShape
looks like:While
NetworkShape.Vow$(shape)
looks likeM.or(shape, VowShape)
.It’s debatable as to how much value
NetworkShape.Vow$
buys us - it seems the.or
forVowShape
will always be the one hit - but in the course of #9449 it felt like a waste to remove shape’s that were previously working and provide helpful cues to the caller.Description of the Design
Decide whether to use
NetworkShape.Vow$
, soon to be renamed toVow$
and exported directly from @agoric/vow, or
VowShape`.Consistently implement the change in
@agoric/orchestration
exos, and only import type guard shapes for vows from@agoric/vow
Security Considerations
Scaling Considerations
Test Plan
Upgrade Considerations
The text was updated successfully, but these errors were encountered: