-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only then
is special. catch
and finally
may validly be in target's method names
#30
Comments
not yet "fixed" https://github.com/endojs/endo/blob/mfig-o/packages/o/index.js#L44 it's not clear to me why this should be constrained by @endo/pass-style, though. OTOH, I don't think I depend on using catch or finally here. |
What other excuse is there for not honoring method names of the target? |
The excuse is that the target, in this case, is hidden behind a Promise facade. Arguably, users may want to deal with a node as if it is actually a promise already ( |
@dckc, consider pulling the latest https://github.com/endojs/endo/blob/mfig-o/packages/o/index.js |
dapp-agoric-basics/contract/tools/ui-kit-goals/name-service-client.js
Line 42 in 5d800a0
This
pmethods
list is used to determine whether an invocation should be treated as calling a method on the target, or treated as a meta-level method for talking to the proxy about the target. However, onlythen
is special.catch
andfinally
may validly be in target's method names. @endo/pass-style only enforces that remotables cannot have their ownthen
method. It has no such rule forcatch
andfinally
.@michaelfig , I'm co-assigning this to you, because it looks like the origin is in your draft
o
package, where this likely also needs to be fixed. (Or is already fixed?)The text was updated successfully, but these errors were encountered: