-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lower-bundle-cost
Done in run-chain.sh
Not Needed Anymore
#96
Labels
enhancement
New feature or request
Comments
@dckc If this sounds ok, I will go and fix this. |
yes, please |
please check whether https://github.com/Agoric/dapp-agoric-basics should get a similar update |
Similarly, consider applying 142bf9a to dapp-agoric-basics. And dapp-orchestration-basics, if it's relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When we start docker, we make
lower-bundle-cost
target in the newly started instance of a3p to lower the cost of bundle - this is replaying proposal 61. But it seems that latesta3p
instance that is used in dapp-offer-up has already lowered bundle cost as expected.We see the following in the output when we run
agd q swingset params
(whilemake -C /workspace/contract lower-bundle-cost
is commented out):- beans: "20000000" key: storageByte
Therefore, it seems that we should remove the following in
run-chain.sh
and corresponding targets in
Makefile
and in any other scripts.The text was updated successfully, but these errors were encountered: