Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uploading required screenshots for UI component docs #1073

Closed
wants to merge 1 commit into from

Conversation

otoole-brendan
Copy link
Contributor

Screenshots that are needed for UI component documentation

@otoole-brendan otoole-brendan self-assigned this May 1, 2024
Copy link

Deploying documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: 936bcdb
Status: ✅  Deploy successful!
Preview URL: https://498d74a5.documentation-7tp.pages.dev
Branch Preview URL: https://otoole-brendan-uicomponents.documentation-7tp.pages.dev

View logs

Copy link

github-actions bot commented May 1, 2024

Cloudflare deployment logs are available here

Copy link
Contributor

@kbennett2000 kbennett2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@dckc
Copy link
Member

dckc commented May 1, 2024

do these belong in the /getting-started/ directory?

@dckc
Copy link
Member

dckc commented May 1, 2024

Also, any particular reason to land this PR separately from #1074? This PR won't result in any visible changes to the docs.

@otoole-brendan
Copy link
Contributor Author

@dckc #1074 points to these .png files that need to be in the assets file before displaying correctly. I wasn't aware I could upload the files as part of #1074 - that would have been the better thing to do. But per your point (and my other comment on #1074) - it sounds like these need to be in their own assets file and not 'Getting Started' if I want them on the same hierarchy/level as 'Getting Started', not within

@kbennett2000
Copy link
Contributor

@otoole-brendan - Maybe a folder under main/guides for ui related docs? Then it would live at the same level as getting started...

@otoole-brendan
Copy link
Contributor Author

Redundant due to #1084

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants