Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Files for Sequence Diagrams #1242

Open
amessbee opened this issue Oct 14, 2024 · 4 comments · May be fixed by #1243
Open

Multiple Files for Sequence Diagrams #1242

amessbee opened this issue Oct 14, 2024 · 4 comments · May be fixed by #1243
Assignees

Comments

@amessbee
Copy link
Contributor

ATM, for each sequence diagram (e.g. one at the bottom of https://docs.agoric.com/guides/orchestration/) in documentation, we are keeping two files

  • .svg diagram graphic to be displayed on docs pages
  • .mmd mermaid source file to generate sequence diagram from

This is a potential duplication of information that requires more than required amount effort to maintain.

@amessbee amessbee self-assigned this Oct 14, 2024
@amessbee amessbee linked a pull request Oct 15, 2024 that will close this issue
@dckc
Copy link
Member

dckc commented Oct 15, 2024

This increases dependence on client-side JavaScript. Before this change, the source (from curl) includes:

... cross-chain transactions.</p><br><img src="/assets/orchestration-workflow-1.CN3JBV8-.svg" width="100%"><br></div>

but with this change, we get:

... cross-chain transactions.</p><div class="mermaid"></div>

It's not clear why JavaScript should be required for static images.

@dckc
Copy link
Member

dckc commented Oct 15, 2024

The indirect dependencies brought in by vitepress-plugin-mermaid include d3, katex, vscode-languageserver, and so on. I wonder if all that is worthwhile.

@amessbee
Copy link
Contributor Author

This increases dependence on client-side JavaScript. Before this change, the source (from curl) includes:

... cross-chain transactions.</p><br><img src="/assets/orchestration-workflow-1.CN3JBV8-.svg" width="100%"><br></div>

but with this change, we get:

... cross-chain transactions.</p><div class="mermaid"></div>

It's not clear why JavaScript should be required for static images.

I don't know enough javascript to be sure, but I believe <div class="mermaid"> is just a static stylesheet class to be (optionally) defined by us, and does not affect the rendering of svg if you remove or change it (in a not-so-adversarial way I suppose).

@dckc
Copy link
Member

dckc commented Oct 16, 2024

It's not clear why JavaScript should be required for static images.

I don't know enough javascript to be sure, but I believe <div class="mermaid"> is just a static stylesheet class to be (optionally) defined by us, and does not affect the rendering of svg if you remove or change it (in a not-so-adversarial way I suppose).

<div class="mermaid"> affects the rendering of the svg image in that (without JavaScript) it provides no rendering whatsoever. Not even a link where you could download the image. Note the lack of an <img> element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants