Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit method signature documentation for accuracy, especially w.r.t. promises #666

Open
gibson042 opened this issue Apr 11, 2022 · 1 comment
Open

Audit method signature documentation for accuracy, especially w.r.t. promises #666

gibson042 opened this issue Apr 11, 2022 · 1 comment
Labels
documentation ERTP Zoe

Comments

@gibson042
Copy link
Member

gibson042 commented Apr 11, 2022 •
edited
Loading

Spawned from #655 (comment) :

the [issuer.burn payment] parameter should have been typed ERef<Payment> [rather than Payment]. Why didn't TS alert us to this mismatch?
@gibson042 gibson042 mentioned this issue Apr 11, 2022
Merged
@dckc
Copy link
Member

dckc commented Apr 13, 2022

see also Agoric/agoric-sdk#4291 Sync Zoe JSDoc with API docs

@Tyrosine22 Tyrosine22 assigned Tyrosine22 and unassigned Tyrosine22 Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation ERTP Zoe
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dckc @Tartuffo @ivanlei @gibson042 @Tyrosine22