Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require luxon as a dependency #147

Closed
jpike88 opened this issue May 27, 2019 · 9 comments
Closed

Require luxon as a dependency #147

jpike88 opened this issue May 27, 2019 · 9 comments

Comments

@jpike88
Copy link

jpike88 commented May 27, 2019

I'd rather not have to remember that luxon has to be installed if this library has it has a hard requirement. It should be pulled in as a dependency automatically.

@Emxm3
Copy link

Emxm3 commented May 28, 2019

^ Aaaaand this comment just solved my issue.....

@jpike88
Copy link
Author

jpike88 commented May 29, 2019

@Agranom poke...

@Agranom
Copy link
Owner

Agranom commented May 29, 2019

I'll check the possibility.

@Agranom
Copy link
Owner

Agranom commented Jun 13, 2019

Done

@Agranom Agranom closed this as completed Jun 13, 2019
@tolotrasamuel
Copy link

It also require @types/luxon to be installed otherwise, angular compiler fails

@Agranom
Copy link
Owner

Agranom commented Jul 15, 2019

I'll check it

@mackelito
Copy link

Looks like this issue has made a comeback? :D

@jpike88
Copy link
Author

jpike88 commented Aug 20, 2019

It still shows as a dependency in package.json, what exactly is the problem

@mackelito
Copy link

My bad! 😬
the package.json was not up to snuff! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants