Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngx-timepicker-field problem with HH input in 12 hours format #243

Closed
Esmodeo opened this issue Oct 18, 2019 · 19 comments
Closed

ngx-timepicker-field problem with HH input in 12 hours format #243

Esmodeo opened this issue Oct 18, 2019 · 19 comments

Comments

@Esmodeo
Copy link

Esmodeo commented Oct 18, 2019

Focus input - backspace to clear hours = no placeholder, but digit 1 appears...
I can't type hours between 2 and 9 in hours field without using arrows or select all in input (only in 12 hours format) http://prntscr.com/pl40zu

@Agranom
Copy link
Owner

Agranom commented Oct 22, 2019

will check

@robert-king
Copy link

not sure if this is the same issue or not, but i'm getting "0" instead of "00" - not sure if that's by design or not, not a big issue though.

Screen Shot 2019-10-24 at 12 12 54 PM

Screen Shot 2019-10-24 at 12 12 59 PM

Screen Shot 2019-10-24 at 12 13 33 PM

Screen Shot 2019-10-24 at 12 14 47 PM

Thanks for a great library. One more thing - Luxon.js does add some bloat just fyi.

@Agranom
Copy link
Owner

Agranom commented Oct 25, 2019

@robert-king I guess your issue is more relative to #241 this one

@Esmodeo
Copy link
Author

Esmodeo commented Oct 27, 2019

@Agranom any chance you will fix problem with hours input in 12h format field?

@Agranom
Copy link
Owner

Agranom commented Oct 28, 2019

Yes, I will. Just need more time for that

@Agranom Agranom added the in progress started implementation label Nov 2, 2019
@Agranom
Copy link
Owner

Agranom commented Nov 2, 2019

It should be fixed. Update to v5.2.2 and check please

@Agranom Agranom added in review awaiting feedback and removed in progress started implementation labels Nov 2, 2019
@Dona278
Copy link

Dona278 commented Nov 4, 2019

@Agranom I've the same issue with 24h format and v5.2.2.
If I have a number already set from model or if I have the input placeholder then the first input is taken and formatted (eg. "2" => "02").
I reproduced the issue also in this way:

Initial state: 11:00
image

Go on hours input with tab or mouse, then press "2"
image
No other input allowed

Go to the minutes input and return back to the hours (or lose and gain focus), press "2" again;
image
Digits aren't formatted and now the input field accept another input before formatting, even if I move to another element and then go back.

Same issue with input placeholer as initial state.

@Agranom
Copy link
Owner

Agranom commented Nov 4, 2019

Are you facing this bug on the demo page? Because I cannot reproduce it.

@Dona278
Copy link

Dona278 commented Nov 4, 2019

Yes!

Initial state:
image

After press "1"
image

@Agranom
Copy link
Owner

Agranom commented Nov 4, 2019

I see the different bug ) When I press '1' an hour changes to '02' instead of '01'. But not bug with formatting

@Dona278
Copy link

Dona278 commented Nov 6, 2019

Maybe depends on the browser language?
However if you digit '1' and the input shows '02', you can digit also another number for example '2' to get '22:00'?

@Agranom
Copy link
Owner

Agranom commented Nov 21, 2019

Update to v5.2.3 and check pls

@Dona278
Copy link

Dona278 commented Nov 21, 2019

Same issue..

@Agranom
Copy link
Owner

Agranom commented Dec 21, 2019

@Dona278 could you pls describe the bug ?

@AdditionAddict
Copy link

AdditionAddict commented Jan 23, 2020

Different platform keyboard behaviour of the ngx-timepicker-field:-

iPad

  • works well typing '11' results in '11'
  • doesn't matter where cursor is if clicking into field
  • tabbing into field also works
  • keyboard shows letters rather than numbers (possible fix is to put type="tel" on the input)

Windows Desktop (Chrome / Firefox) - same as described by @Dona278

  • practically unusable
  • typing '11' results in '01' no matter where cursor is or if you tab into hour/minute field
  • only way to enter is type '1', back arrow, delete (←), type '1' or to use up/down arrows which is slow

@Agranom
Copy link
Owner

Agranom commented Jan 23, 2020

Did you try on window desktop?

@AdditionAddict
Copy link

Did you try on window desktop?

Apologies above was for Windows (post edited to reflect)

@Agranom
Copy link
Owner

Agranom commented Feb 18, 2020

Do you use right side numbers on your keyboard?

@Agranom Agranom removed the in review awaiting feedback label Feb 29, 2020
@Agranom
Copy link
Owner

Agranom commented Feb 29, 2020

The issue is resolved. Update to the latest version (v.5.4.0).

@Agranom Agranom closed this as completed Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants