Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time range selection (min, max) not working correctly #43

Closed
Zaheer211 opened this issue Sep 25, 2018 · 18 comments
Closed

Time range selection (min, max) not working correctly #43

Zaheer211 opened this issue Sep 25, 2018 · 18 comments

Comments

@Zaheer211
Copy link

We're using ngx-material-timepicker in our project and came across an issue in range time selection.
Here is input element for time-picker.

<input matInput type="text" [ngClass]="{'time myInput': true, smallFont: popupView}" formControlName="time" [ngxTimepicker]="picker" placeholder="Add time" min="09:00 am" max="03:00 pm" readonly>

<ngx-material-timepicker [ngClass]="{'timePicker': true}" (timeSet)="onTimeSet($event)" #picker></ngx-material-timepicker>

Expected:
It should allow to select anytime between 09:00 am to 03:00 pm.

Problem:
12:00 pm to 12:59 pm can't be selected. Event though it lies within the above range.

Two screenshots are attached to support above argument.

screenshot from 2018-09-25 09-38-44

screenshot from 2018-09-25 09-39-12

Thanks in advance for any help!

@Agranom
Copy link
Owner

Agranom commented Sep 25, 2018

I see. I'll check it

@Agranom
Copy link
Owner

Agranom commented Oct 7, 2018

Fixed, sorry for so long. Update to the latest version and try

@Zaheer211
Copy link
Author

Zaheer211 commented Oct 7, 2018

I have update to latest version 2.6.2 and now within the range (11:00 am to 03:00 pm) minutes are not select-able for 1 pm, 2 pm and 3 pm. Which is very strange as it was working well in earlier version.
Attaching screenshots to support my argument.

screenshot from 2018-10-07 17-43-26
screenshot from 2018-10-07 18-30-15
screenshot from 2018-10-07 18-30-38

@Agranom
Copy link
Owner

Agranom commented Oct 7, 2018

I see, I guess it’s because of refactoring. I’ll figure out what the problem is and fix ASAP

@Agranom
Copy link
Owner

Agranom commented Oct 8, 2018

Update to 2.6.3 and try it out please

@Zaheer211
Copy link
Author

Hi Agranom!
Thanks for your efforts but now the previous issue is somewhat back again where time between 12:00 pm to 12:59 pm was not select-able in allowed range of 11:00 am to 03:00 pm.
Although one improvement is that now 12 can be selected from hours which previously was not working.
But minutes are not select-able when 12 is selected.
Let me share a screen shot for this situation

screenshot from 2018-10-08 21-00-25

@Agranom
Copy link
Owner

Agranom commented Oct 8, 2018

Oh, sorry. I've aready found the problem and fix it in the next release with other bugfixes

@Zaheer211
Copy link
Author

Sorry but in the above screenshot I'm using version 2.6.3 and I can't see more updated version than that.

@Agranom
Copy link
Owner

Agranom commented Oct 9, 2018

I haven't publish yet )

@nicolalopatriello
Copy link

nicolalopatriello commented Oct 9, 2018

Hi, i've the some problem of @Zaheer211 . It's solved?
Thanks

@Zaheer211
Copy link
Author

Not solved yet. Waiting for the fixed version.

@Agranom
Copy link
Owner

Agranom commented Oct 10, 2018

Already published. Try :)

@Agranom
Copy link
Owner

Agranom commented Oct 12, 2018

Have you tried yet?

@Zaheer211
Copy link
Author

Zaheer211 commented Oct 12, 2018

I tried it just now and now hours out of range are correctly disabled. But minutes out of range are not getting disabled.
Here are the screenshots for case 11:15 am to 03:25 pm.

screenshot from 2018-10-12 19-09-47
screenshot from 2018-10-12 19-11-11

@Agranom
Copy link
Owner

Agranom commented Oct 15, 2018

Sorry, my fault. Already fixed it. Update to 2.6.5 pls

@Zaheer211
Copy link
Author

Thanks - I'll check and let you know.

@Agranom
Copy link
Owner

Agranom commented Oct 22, 2018

Have you checked?

@Zaheer211
Copy link
Author

Hey Agranom! This issue seems resolved in version 2.8.0. Thanks for your great support, I'm closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants