Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request - editable time inputs #49

Closed
rainbird17 opened this issue Oct 8, 2018 · 9 comments
Closed

Feature request - editable time inputs #49

rainbird17 opened this issue Oct 8, 2018 · 9 comments

Comments

@rainbird17
Copy link

Some of our clients have requested the ability to click on the actual numbers that display the Time and directly edit them via keyboard (so they don't have to move the clock hands).

Would this be possible to add as an optional feature?

Thanks for your consideration.

@Agranom
Copy link
Owner

Agranom commented Oct 9, 2018

Hi. I'll think about it right after refactoring )

@jbthomps
Copy link

For my use case similar to this, it would be helpful to simply be able to edit the underlying input area in a consistent way and have it reflect back in the clock so that users don't necessarily have to go into the clock at all to enter something.

@Agranom
Copy link
Owner

Agranom commented Oct 18, 2018

already started implementing this feature. I guess it'll be done till the end of this week

@Agranom
Copy link
Owner

Agranom commented Oct 21, 2018

I implemented the feature. Update to 2.7.0 and look at the demo how to use it. Tell me your opinion about it please

@jbthomps
Copy link

From what I'm seeing, this looks really close. The only thing that I see that's missing is input restriction (I can type any number of digits into the timepicker), and the ability to tab to AM/PM in the 12 hour clock.

My personal hope would be to have the input field itself that you focus editable when clicking on it, but it is somewhat separate from this original request, and I can raise it as a new issue if it'll make things easier.

@Agranom
Copy link
Owner

Agranom commented Oct 23, 2018

Yes, make it as a new issue please

@rainbird17
Copy link
Author

I have the same thoughts:

  • Input restriction to valid chars - I can type letters and other characters, it should only allow numbers
  • Input restricted to 2 digits
  • Input restricted to valid time (I should not be able to type 61 minutes, for example)
  • Focus on click - I would prefer the numbers to be focused when first entering edit mode, it makes changing the value easier
  • Add the ability to edit/tab to the AM/PM field so you can use keyboard there too
  • Can we have the arrow keys move the values up/down?

Should I add these to a single new issue? Or append them to jbthomps issue? (not sure if he created it yet)

@Agranom
Copy link
Owner

Agranom commented Oct 23, 2018

You guys can merge your proposals to one issue, so that I can close this one. Thanks

@rainbird17
Copy link
Author

fyi: I created issue #56 for my enhancement requests....

Thank you so much for implementing this feature!

@Agranom Agranom closed this as completed Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants