Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XSIMD backend produces bad sounding plugin on Dwarf platform, EIGEN is not #6

Open
MaxPayne86 opened this issue Mar 6, 2023 · 7 comments
Labels
bug Something isn't working

Comments

@MaxPayne86
Copy link
Contributor

This can be replicated with https://github.com/moddevices/mod-plugin-builder/blob/f73345bc16e64b048aa06df7bac3218ba9094782/plugins/package/aidadsp-lv2/aidadsp-lv2.mk#L7

-AIDADSP_LV2_VERSION = 0bac2f3feb811115d696b11ec2293f5f03a535ac
+AIDADSP_LV2_VERSION = 6e54495ce95bcbaf2432ef4a3931299492b14671
...
-AIDADSP_LV2_CONF_OPTS = -DRTNEURAL_EIGEN=ON
+AIDADSP_LV2_CONF_OPTS = -DRTNEURAL_XSIMD=ON

this is not happening on other build systems like yocto and this could help in identifying the issue.

The issue should be related on how MPB builds xsimd backend in RTNeural submodule and not on plugin source code.

@falkTX

@MaxPayne86 MaxPayne86 changed the title XSIMD backed produces bad sounding plugin on Dwarf platform, EIGEN is not XSIMD backend produces bad sounding plugin on Dwarf platform, EIGEN is not Mar 6, 2023
@falkTX
Copy link
Collaborator

falkTX commented Mar 9, 2023

Your own yocto file has a very interesting line:

-funsafe-loop-optimizations causes the plugin to sound really bad, excluding

Maybe it is this simple...

@falkTX
Copy link
Collaborator

falkTX commented Mar 9, 2023

Yep, that seems to be the case.
Fixed in mod-audio/mod-plugin-builder@a41eac6
Took the chance to enable LTO as well, for a little extra performance benefit.

@falkTX
Copy link
Collaborator

falkTX commented Mar 9, 2023

Might have spoken too soon. behaviour improves but issue still there.

@MaxPayne86
Copy link
Contributor Author

@falkTX being a distortion effect, discussing about sound distorted may became an issue: the problem creates a corrupted sound similar to random noise and crackling mixed with the distorted sound can you confirm? Thanks a lot

@falkTX
Copy link
Collaborator

falkTX commented Mar 9, 2023

There is a high-pitch crackling noise still present. Still investigating...

@falkTX
Copy link
Collaborator

falkTX commented Mar 9, 2023

Something relevant to xsimd vs eigen.. we actually have better performance when using eigen backend.
So perhaps the whole deal is a bit pointless

@MaxPayne86
Copy link
Contributor Author

I agree to stay with eigen for now, the only replicable solution to me could be

  • if in RTNeural we have a benchmark test for backends using static models

need to check

@MaxPayne86 MaxPayne86 added the bug Something isn't working label Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants