Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improv broken in 0.15.0-b5 #4173

Closed
1 task done
Xevel opened this issue Oct 2, 2024 · 1 comment
Closed
1 task done

Improv broken in 0.15.0-b5 #4173

Xevel opened this issue Oct 2, 2024 · 1 comment
Labels

Comments

@Xevel
Copy link
Contributor

Xevel commented Oct 2, 2024

What happened?

Improv rejects all incoming packets.
Bug happened in commit efa32ed.

Cause is that the checksum (l.48) that used to be an "uint8_t" has been changed to a "unsigned" without adding code to keep the value in the same range as before. It thus is not equal to the checksum at the end of the packet.

To Reproduce Bug

Try to use Improv, it rejects all communication, answering INVALID_RPC_PACKET.

Expected Behavior

Improv correctly parses incoming packets.

Install Method

Self-Compiled

What version of WLED?

0.15.0-b5

Which microcontroller/board are you seeing the problem on?

ESP32-S3

Relevant log/trace output

No response

Anything else?

Either restore type to uint8_t, or for example add l.126:
checksum &= 0xFF;

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Xevel Xevel added the bug label Oct 2, 2024
@blazoncek
Copy link
Collaborator

Please provide a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants