Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling brightness limiter requires additional changes before saving #4277

Open
1 task done
Fonzi03 opened this issue Nov 13, 2024 · 7 comments
Open
1 task done
Labels
bug cannot reproduce Developers are not able reproduce. Might be fixed already, or report is missing important details

Comments

@Fonzi03
Copy link

Fonzi03 commented Nov 13, 2024

What happened?

Cannot save after disabling automatic brightness

To Reproduce Bug

If you go to LED Preferences and de-select "Enable automatic brightness limiter" and try to save without making any other changes you cannot save. Change any value anywhere else and you can save.

Expected Behavior

you should be able to save after changing a setting.

Install Method

Binary from WLED.me

What version of WLED?

2410270

Which microcontroller/board are you seeing the problem on?

ESP32

Relevant log/trace output

No response

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Fonzi03 Fonzi03 added the bug label Nov 13, 2024
@softhack007 softhack007 added the needs investigation The bug has not yet been reproduced by me. Analysis or more details are needed. label Nov 18, 2024
@softhack007
Copy link
Collaborator

As this affects the LEDs settings page, it would be good to understand what's going on before 0.15.0-RC1 #4287

@Fonzi03
Copy link
Author

Fonzi03 commented Nov 22, 2024

As this affects the LEDs settings page, it would be good to understand what's going on before 0.15.0-RC1 #4287

If you need me to test anything or provide more details I'm more than happy to do so.

@DedeHai DedeHai added the cannot reproduce Developers are not able reproduce. Might be fixed already, or report is missing important details label Nov 24, 2024
@DedeHai
Copy link
Collaborator

DedeHai commented Nov 24, 2024

I just tried this and and saving works.
@Fonzi03 did you try this on a fresh install or what is the history? Did you try clearing local browser storage?

@Fonzi03
Copy link
Author

Fonzi03 commented Nov 24, 2024

I just tried this and and saving works.
@Fonzi03 did you try this on a fresh install or what is the history? Did you try clearing local browser storage?

I don't remember if when this occured it was on a fresh install or not. I was having multiple different issues at the time and flashed a handful of times. If it can't be reproduced it's likely it was a secondary order issue.

I can test again but probably not for another week or so.

@netmindz netmindz removed the needs investigation The bug has not yet been reproduced by me. Analysis or more details are needed. label Nov 24, 2024
@dosipod
Copy link
Contributor

dosipod commented Nov 25, 2024

If by "requires additional changes before saving" meaning it will not save unless you enter the "Maximum PSU Current" and next time also enter the "mA/LED" then yes we have reported that among others multiple times . Mostly in discord but I think it was seen as not important

Uploading pref_no_save.mov…

edit: Could not load video to this page for some reson , it is here
dosipod#1

@Fonzi03
Copy link
Author

Fonzi03 commented Nov 25, 2024

If by "requires additional changes before saving" meaning it will not save unless you enter the "Maximum PSU Current" and next time also enter the "mA/LED" then yes we have reported that among others multiple times . Mostly in discord but I think it was seen as not important

Uploading pref_no_save.mov…

Precisely the issue, except it's not limited to mA/LED you just have to change literally any other value on the page for it to them allow saving.

@dosipod
Copy link
Contributor

dosipod commented Nov 25, 2024

Just to clarify as I had issue loading the video , in my test the issue is once you check the limiter so not the other way around , can you take a video of the issue so it is more clear

@softhack007 softhack007 added this to the 0.15.1 candidate milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cannot reproduce Developers are not able reproduce. Might be fixed already, or report is missing important details
Projects
None yet
Development

No branches or pull requests

5 participants