-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send ArtnetPollReply for Art-Net proxy universe #3892
Conversation
@mxklb @troyhacks @netmindz as you have more DMX experience can you verify/review this PR, please? |
Is there an associated issue detailing what the issue is that this PR seeks to resolve? It's hard to review a solution without a clear understanding of the intention |
I think it's a feature enhancement. With some of the existing WLED code we can automatically detect Art-Net endpoints, and this appears to extend this to the Art-Net proxy system. I haven't used this functionality but I don't think there's any risk in adding it. Art-Net users at this level are few, I think. I'm one of them and I'm still kinda like ... whut? 😁 |
Yes, that's correct. This is a nice feature to get a quick overview (for example in QLC) of the available Art-Net nodes in the network and it would be useful if it also worked for proxied DMX outputs. |
I'm good with adding this. Thanks, @askask |
Looking good. I'm not using this artnet poll feature, so can't test it, but looks like an improvement for DMX proxy. Save to merge |
This commit adds sending an ArtnetPollReply for the e131ProxyUniverse, which is currently not implemented.
It also checks that this universe doesn't overlap with the regular e131Universe, so no duplicate replies are sent.