Added BRT timezone #4188
Open
Added BRT timezone #4188
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aircoookie
approved these changes
Oct 12, 2024
There was a problem hiding this comment.
I approve of this change.
In general and thinking long term, I think we could consider storing time zones in JS as json (or potentially even loading them in externally so that every actual timezone is also supported) and only passing UTC offset + DST change dates to the ESP as settings. Not pressing though as more timezone entries do not require extra RAM at least.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the Brasília timezone, which is widely used across most regions of Brazil.