Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Only Show Unsigned Chat" #417

Open
IlyaYezelovsky opened this issue Jul 25, 2023 · 8 comments
Open

"Only Show Unsigned Chat" #417

IlyaYezelovsky opened this issue Jul 25, 2023 · 8 comments
Assignees
Labels
enhancement New feature or request low priority

Comments

@IlyaYezelovsky
Copy link
Contributor

Idea

Do the opposite of the vanilla Minecraft - change the "Only Show Secure Chat" option to "Only Show Unsigned Chat".

Reasoning

Just make players who has No Chat Reports cannot see signed messages.
It is somewhat similar to #373

Other Information

Disabled by default

@IlyaYezelovsky IlyaYezelovsky added the enhancement New feature or request label Jul 25, 2023
@Madis0
Copy link
Collaborator

Madis0 commented Jul 25, 2023

Where would anyone benefit from this setting?

There are quite few servers that even allow raw unsigned messages (compared to disallowing or converting them), mostly vanilla ones. So, on those servers - that have few players anyway - you'd just not see most users' messages? Maybe there'd be some angry admins telling you to enable chat reporting and you'd never see it.

I'd understand the viewpoint if raw unsigned messages would be allowed on big servers like Hypixel, so you could have like a "group chat" of sorts, but since it isn't, I feel like this option would just break the game even more than the original one.

@IlyaYezelovsky
Copy link
Contributor Author

IlyaYezelovsky commented Jul 27, 2023

There are quite few servers that even allow raw unsigned messages

The vast majority of servers (at least those I have played) have enforce-secure-profile=false set, and I rarely see signed messages on them.

The "group chat" is one of my idea.

@Madis0
Copy link
Collaborator

Madis0 commented Jul 27, 2023

The vast majority of servers (at least those I have played) have enforce-secure-profile=false set, and I rarely see signed messages on them.

That is true, but in the majority you don't see unsigned messages either, you just see the system messages, hence my question.

@IlyaYezelovsky
Copy link
Contributor Author

However, system messages are not signed messages.

Players mostly use unoffical launchers, they cannot fetch keys. This means they CANNOT send signed messages at all (with or without NCR).

So I just want a function like this :) If you won't add it, I won't be sad

@Madis0
Copy link
Collaborator

Madis0 commented Jul 27, 2023

Players mostly use unoffical launchers, they cannot fetch keys. This means they CANNOT send signed messages at all (with or without NCR).

In such servers, it is not possible to send signed messages even with an official launcher. Hence I'm trying to find use cases where this would benefit the user.

So, do you know any servers where:

  • chat signing is optional
  • chat is not converted to system messages
  • at least 50% of users are aware of NCR?

@IlyaYezelovsky
Copy link
Contributor Author

IlyaYezelovsky commented Jul 27, 2023

mc.kianakiferi.cn and mc.touchafish.cc for 1.20.1

@Madis0
Copy link
Collaborator

Madis0 commented Sep 9, 2023

mc.kianakiferi.cn and mc.touchafish.cc for 1.20.1

Hmm. So I tested them out:

  • The first one keeps complaining that authentication servers are down, even though I can join every other online server just fine.
  • The second one kicked me with the reason "please use a genuine account to join the server", though after a relog it still let me in (online account). Though yes, you're right about the chat signing being optional in this server.

With that in mind, I am not sure about your claim

Players mostly use unoffical launchers, they cannot fetch keys. This means they CANNOT send signed messages at all (with or without NCR).

if neither of the servers didn't even want to let me in due to authentication problems...

@IlyaYezelovsky
Copy link
Contributor Author

IlyaYezelovsky commented Feb 7, 2024

Players mostly use unoffical launchers, they cannot fetch keys. This means they CANNOT send signed messages at all (with or without NCR).
This's the TRUE situation in China.
An example: https://github.com/Hex-Dragon/PCL2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority
Projects
None yet
Development

No branches or pull requests

3 participants