Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow retrying health check, or wait for preboot #77

Open
wbobeirne opened this issue Mar 2, 2021 · 0 comments · May be fixed by #78
Open

Allow retrying health check, or wait for preboot #77

wbobeirne opened this issue Mar 2, 2021 · 0 comments · May be fixed by #78

Comments

@wbobeirne
Copy link

I'm working on a project that's using Heroku's preboot for zero downtime. As far as I can tell they don't have an easy way to indicate when it's done with prebooting, so I've decided to implement my own custom healthcheck that will report the commit hash that it's currently running on.

Unfortunately unless I set an incredibly long delay, I won't be able to use the healthcheck option provided here because I have no guarantee of when the preboot has switched over. This would be a lot easier if I had an option to retry the health check some number of times, with some delay between them.

Alternatively this would be a ton easier if there was some way to have the step only advance when the preboot has flipped over!

@wbobeirne wbobeirne linked a pull request Mar 2, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant