Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

References in JOSS paper #1

Closed
landreman opened this issue Nov 25, 2024 · 7 comments
Closed

References in JOSS paper #1

landreman opened this issue Nov 25, 2024 · 7 comments

Comments

@landreman
Copy link

For the JOSS review:

Googling around quickly, it looks like another project to connect mpi with jax is https://github.com/mpi4jax/mpi4jax. How about citing their paper and adding a few words in your manuscript about the similarities/differences?

Also some info is missing on the Scott reference.

@AlanPearl
Copy link
Owner

  • The Scott reference is now fixed: f9e0146
  • Thanks for bringing up mpi4jax, I will definitely cite it and add some clarification on why to use one or the other...

@ewu63
Copy link

ewu63 commented Nov 30, 2024

Chiming in on the JOSS review as well:

  • I'm not familiar with jax in the context of distributed memory parallelism, but OpenMDAO from NASA Glenn is another computational framework that can 1) assemble derivatives of multiple components via the chain rule, and 2) work with parallel components under MPI. Might be worth referencing. I know you're basing the derivatives on jax which has some advantages which you can point out, such as efficient gradient computation via AD.
  • Parallel PSO is an idea that has been implemented before. I don't know any references off the top of my head, so this is certainly not something you need to do, but any references to existing implementations I think would be helpful.

@AlanPearl
Copy link
Owner

I have pushed changes to the statement of need in a2b6e83 including references to similar past efforts, including the two mentioned in this thread. How does this look?

@landreman
Copy link
Author

Looks good to me

@ewu63
Copy link

ewu63 commented Dec 5, 2024

Good with me as well

@jbytecode
Copy link

Can we please close the resolved issues?

@AlanPearl
Copy link
Owner

Yes, this is now closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants