Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disabled styles do not match other disabled auro components #185

Closed
cynthiaricomendoza-alaskaair opened this issue Apr 24, 2024 · 3 comments · Fixed by #189
Closed

disabled styles do not match other disabled auro components #185

cynthiaricomendoza-alaskaair opened this issue Apr 24, 2024 · 3 comments · Fixed by #189
Assignees
Labels
auro-select Type: Bug Bug or Bug fixes

Comments

@cynthiaricomendoza-alaskaair
Copy link

cynthiaricomendoza-alaskaair commented Apr 24, 2024

Describe the bug

when the auro-select component is disabled, it has an opacity set to 0.7 causing it to not appear the same as auro-input and auro-combobox when they are also disabled.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://auro.alaskaair.com/components/auro/select and scroll to the disabled example
  2. Inspect the disabled auro-select component
  3. Observe host([disabled]) has opacity set to 0.7
  4. Go to https://auro.alaskaair.com/components/auro/input and scroll to the disabled example
  5. Inspect the disabled auro-input component
  6. Observe host([disabled]) does not have an opacity set

Expected behavior

If auro components support the disabled property and they are set to disabled, I would like to see the styles be consistent across all components.

Screenshots

Here is an example of what the disabled auro-combobox, auro-select, and auro-input look like beside one another.

Screenshot 2024-04-24 at 16 40 45

Desktop (please complete the following information):

  • OS: iOS
  • Browser: Chrome
  • Version: latest

Smartphone (please complete the following information):

  • Device: N/A
  • OS: N/A
  • Browser N/A
  • Version N/A

Additional context

When I uncheck the opacity style in the dev tools, auro-select now has the same disabled styling as auro-combobox and auro-input:
Screenshot 2024-04-24 at 17 17 45

@cynthiaricomendoza-alaskaair cynthiaricomendoza-alaskaair added not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes auro-select labels Apr 24, 2024
@cynthiaricomendoza-alaskaair cynthiaricomendoza-alaskaair changed the title disabled styles do not match other auro components disabled styles do not match other disabled auro components Apr 24, 2024
@Patrick-Daly-AA
Copy link

This will be fixed as part of our larger theming and token overhaul we are in progress on.

@cynthiaricomendoza-alaskaair
Copy link
Author

thanks for the update @Patrick-Daly-AA! do you have an estimate on when that work will be complete?

@Patrick-Daly-AA
Copy link

@cynthiaricomendoza-alaskaair , We're expecting theming work for colors to be completed in early June at the latest. If you need a fix sooner, let us know and we can either do a one-off fix for this, or can ensure that we cover this early in the theming release(s).

@blackfalcon blackfalcon removed the not-reviewed Issue has not been reviewed by Auro team members label May 13, 2024
@braven112 braven112 self-assigned this May 24, 2024
@braven112 braven112 linked a pull request May 24, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auro-select Type: Bug Bug or Bug fixes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants