Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regions without shortCode can't be selected #325

Open
AlbertoPdRF opened this issue Oct 5, 2020 · 0 comments
Open

Regions without shortCode can't be selected #325

AlbertoPdRF opened this issue Oct 5, 2020 · 0 comments
Labels
bug Something isn't working dependencies Related to external dependencies full stack Requires work on both the front and back ends of the application good first issue Good for newcomers hacktoberfest Recommended issues for hacktoberfest participants

Comments

@AlbertoPdRF
Copy link
Owner

Describe the bug

We are using country-region-data as our list of countries and regions. It turns out that there are some regions without short codes, as can be seen in country-regions/country-region-data#70. As a result of this, there are some regions that can't be selected when creating/updating a user or an event, as we expect them to have a short code.

To Reproduce
Steps to reproduce the behavior:

  1. Go to update a user
  2. Select Cayman Islands as their country
  3. Select any of its regions
  4. Click Save
  5. See error

Expected behavior

Regions without short codes should be selectable too.

Additional context

This problem was originally discovered here. As done there, we can use the region name as a fallback until the upstream issue referenced above is fixed.

@AlbertoPdRF AlbertoPdRF added bug Something isn't working dependencies Related to external dependencies full stack Requires work on both the front and back ends of the application labels Oct 5, 2020
@AlbertoPdRF AlbertoPdRF added good first issue Good for newcomers hacktoberfest Recommended issues for hacktoberfest participants labels Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Related to external dependencies full stack Requires work on both the front and back ends of the application good first issue Good for newcomers hacktoberfest Recommended issues for hacktoberfest participants
Projects
None yet
Development

No branches or pull requests

1 participant