Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules do not appear in the admin navigation #1490

Closed
westonganger opened this issue Oct 20, 2018 · 2 comments
Closed

Modules do not appear in the admin navigation #1490

westonganger opened this issue Oct 20, 2018 · 2 comments

Comments

@westonganger
Copy link
Contributor

westonganger commented Oct 20, 2018

I following the modules guide, creating my first module, the navigation link never gets added to the left sidebar nav however you can access via the URL and it works fine.

Steps to reproduce

Create a module

Expected behavior

Should provide a navigation link in the sidebar

Actual behavior

No navigation link in the sidebar

System configuration

  • Alchemy Version: 4.2.0.alpha & 4.1.x
  • Rails Version: 5.2.1
  • Contents of your Gemfile.lock
GIT
  remote: git@github.com:AlchemyCMS/alchemy-devise.git
  revision: 086f26990f8212cfe7faaa77c9f93886d797b5f1
  specs:
    alchemy-devise (4.1.0)
      alchemy_cms (>= 4.1.0.beta, < 4.99)
      devise (>= 4.0, < 4.99)

GIT
  remote: git@github.com:AlchemyCMS/alchemy-richmedia-essences.git
  revision: e6e99738a1dbedde00fb29bcd8035280e8107cdc
  specs:
    alchemy-richmedia-essences (2.0.0)
      alchemy_cms (>= 4.0.0.rc1)

GIT
  remote: git@github.com:AlchemyCMS/alchemy_cms.git
  revision: dceb990782fed125e3a7d01eaef2960e0982343d
  specs:
    alchemy_cms (4.2.0.alpha)
      active_model_serializers (~> 0.10.0)
      acts_as_list (~> 0.3)
      awesome_nested_set (~> 3.1)
      cancancan (~> 2.1)
      coffee-rails (~> 4.0)
      dragonfly (~> 1.0, >= 1.0.7)
      dragonfly_svg (~> 0.0.4)
      gutentag (~> 2.2, >= 2.2.1)
      handlebars_assets (~> 0.23)
      jquery-rails (~> 4.0, >= 4.0.4)
      jquery-ui-rails (~> 6.0)
      kaminari (~> 1.1)
      non-stupid-digest-assets (~> 1.0.8)
      originator (~> 3.1)
      rails (~> 5.0, < 6.0)
      ransack (~> 2.0)
      request_store (~> 1.2)
      responders (~> 2.0)
      select2-rails (>= 3.5.9.1, < 4.0)
      simple_form (~> 4.0)
      turbolinks (>= 2.5)

GEM
  remote: https://rubygems.org/
  remote: https://rails-assets.org/
  specs:
    actioncable (5.2.1)
      actionpack (= 5.2.1)
      nio4r (~> 2.0)
      websocket-driver (>= 0.6.1)
    actionmailer (5.2.1)
      actionpack (= 5.2.1)
      actionview (= 5.2.1)
      activejob (= 5.2.1)
      mail (~> 2.5, >= 2.5.4)
      rails-dom-testing (~> 2.0)
    actionpack (5.2.1)
      actionview (= 5.2.1)
      activesupport (= 5.2.1)
      rack (~> 2.0)
      rack-test (>= 0.6.3)
      rails-dom-testing (~> 2.0)
      rails-html-sanitizer (~> 1.0, >= 1.0.2)
    actionview (5.2.1)
      activesupport (= 5.2.1)
      builder (~> 3.1)
      erubi (~> 1.4)
      rails-dom-testing (~> 2.0)
      rails-html-sanitizer (~> 1.0, >= 1.0.3)
    active_model_serializers (0.10.7)
      actionpack (>= 4.1, < 6)
      activemodel (>= 4.1, < 6)
      case_transform (>= 0.2)
      jsonapi-renderer (>= 0.1.1.beta1, < 0.3)
    activejob (5.2.1)
      activesupport (= 5.2.1)
      globalid (>= 0.3.6)
    activemodel (5.2.1)
      activesupport (= 5.2.1)
    activerecord (5.2.1)
      activemodel (= 5.2.1)
      activesupport (= 5.2.1)
      arel (>= 9.0)
    activestorage (5.2.1)
      actionpack (= 5.2.1)
      activerecord (= 5.2.1)
      marcel (~> 0.3.1)
    activesupport (5.2.1)
      concurrent-ruby (~> 1.0, >= 1.0.2)
      i18n (>= 0.7, < 2)
      minitest (~> 5.1)
      tzinfo (~> 1.1)
    acts_as_list (0.9.16)
      activerecord (>= 3.0)
    addressable (2.5.2)
      public_suffix (>= 2.0.2, < 4.0)
    airbrussh (1.3.0)
      sshkit (>= 1.6.1, != 1.7.0)
    archive-zip (0.11.0)
      io-like (~> 0.3.0)
    arel (9.0.0)
    autoprefixer-rails (9.2.1)
      execjs
    awesome_nested_set (3.1.4)
      activerecord (>= 4.0.0, < 5.3)
    bcrypt (3.1.12)
    better_errors (2.5.0)
      coderay (>= 1.0.0)
      erubi (>= 1.0.0)
      rack (>= 0.9.0)
    binding_of_caller (0.8.0)
      debug_inspector (>= 0.0.1)
    bootsnap (1.3.2)
      msgpack (~> 1.0)
    builder (3.2.3)
    bullet (5.7.6)
      activesupport (>= 3.0.0)
      uniform_notifier (~> 1.11.0)
    byebug (10.0.2)
    cancancan (2.3.0)
    capistrano (3.11.0)
      airbrussh (>= 1.0.0)
      i18n
      rake (>= 10.0.0)
      sshkit (>= 1.9.0)
    capistrano-alchemy (1.0.0)
      capistrano-rails (~> 1.1)
    capistrano-bundler (1.3.0)
      capistrano (~> 3.1)
      sshkit (~> 1.2)
    capistrano-postgresql (6.2.0)
      capistrano (>= 3.0)
      sshkit (>= 1.17.0)
    capistrano-rails (1.4.0)
      capistrano (~> 3.1)
      capistrano-bundler (~> 1.1)
    capistrano-rbenv (2.1.4)
      capistrano (~> 3.1)
      sshkit (~> 1.3)
    capistrano-rbenv-install (1.2.0)
      capistrano (>= 3.0)
      capistrano-rbenv (>= 2.0)
    capistrano-safe-deploy-to (1.1.1)
      capistrano (>= 3.0)
    capistrano-secrets-yml (1.2.1)
      capistrano (>= 3.10)
      sshkit (>= 1.17.0)
    capybara (3.9.0)
      addressable
      mini_mime (>= 0.1.3)
      nokogiri (~> 1.8)
      rack (>= 1.6.0)
      rack-test (>= 0.6.3)
      xpath (~> 3.1)
    case_transform (0.2)
      activesupport
    childprocess (0.9.0)
      ffi (~> 1.0, >= 1.0.11)
    chromedriver-helper (2.1.0)
      archive-zip (~> 0.10)
      nokogiri (~> 1.8)
    coderay (1.1.2)
    coffee-rails (4.2.2)
      coffee-script (>= 2.2.0)
      railties (>= 4.0.0)
    coffee-script (2.4.1)
      coffee-script-source
      execjs
    coffee-script-source (1.12.2)
    concurrent-ruby (1.0.5)
    crass (1.0.4)
    daemons (1.2.6)
    debug_inspector (0.0.3)
    devise (4.5.0)
      bcrypt (~> 3.0)
      orm_adapter (~> 0.1)
      railties (>= 4.1.0, < 6.0)
      responders
      warden (~> 1.2.3)
    dragonfly (1.1.5)
      addressable (~> 2.3)
      multi_json (~> 1.0)
      rack (>= 1.3)
    dragonfly_svg (0.0.4)
      dragonfly (~> 1.0)
      nokogiri
    erubi (1.7.1)
    eventmachine (1.2.7)
    exception_notification (4.2.2)
      actionmailer (>= 4.0, < 6)
      activesupport (>= 4.0, < 6)
    execjs (2.7.0)
    fast_blank (1.0.0)
    ffi (1.9.25)
    formatador (0.2.5)
    globalid (0.4.1)
      activesupport (>= 4.2.0)
    guard (2.14.2)
      formatador (>= 0.2.4)
      listen (>= 2.7, < 4.0)
      lumberjack (>= 1.0.12, < 2.0)
      nenv (~> 0.1)
      notiffany (~> 0.0)
      pry (>= 0.9.12)
      shellany (~> 0.0)
      thor (>= 0.18.1)
    guard-compat (1.2.1)
    guard-rails (0.8.1)
      guard (~> 2.11)
      guard-compat (~> 1.0)
    gutentag (2.4.0)
      activerecord (>= 3.2.0)
    handlebars_assets (0.23.2)
      execjs (~> 2.0)
      sprockets (>= 2.0.0)
      tilt (>= 1.2)
    i18n (1.1.1)
      concurrent-ruby (~> 1.0)
    io-like (0.3.0)
    jquery-rails (4.3.3)
      rails-dom-testing (>= 1, < 3)
      railties (>= 4.2.0)
      thor (>= 0.14, < 2.0)
    jquery-turbolinks (2.1.0)
      railties (>= 3.1.0)
      turbolinks
    jquery-ui-rails (6.0.1)
      railties (>= 3.2.16)
    jsonapi-renderer (0.2.0)
    kaminari (1.1.1)
      activesupport (>= 4.1.0)
      kaminari-actionview (= 1.1.1)
      kaminari-activerecord (= 1.1.1)
      kaminari-core (= 1.1.1)
    kaminari-actionview (1.1.1)
      actionview
      kaminari-core (= 1.1.1)
    kaminari-activerecord (1.1.1)
      activerecord
      kaminari-core (= 1.1.1)
    kaminari-core (1.1.1)
    listen (3.1.5)
      rb-fsevent (~> 0.9, >= 0.9.4)
      rb-inotify (~> 0.9, >= 0.9.7)
      ruby_dep (~> 1.2)
    lol_dba (2.1.5)
      actionpack (>= 3.0)
      activerecord (>= 3.0)
      railties (>= 3.0)
    loofah (2.2.2)
      crass (~> 1.0.2)
      nokogiri (>= 1.5.9)
    lumberjack (1.0.13)
    mail (2.7.1)
      mini_mime (>= 0.1.1)
    marcel (0.3.3)
      mimemagic (~> 0.3.2)
    method_source (0.9.0)
    mimemagic (0.3.2)
    mini_mime (1.0.1)
    mini_portile2 (2.3.0)
    minitest (5.11.3)
    msgpack (1.2.4)
    multi_json (1.13.1)
    nenv (0.3.0)
    net-scp (1.2.1)
      net-ssh (>= 2.6.5)
    net-ssh (5.0.2)
    nio4r (2.3.1)
    nokogiri (1.8.5)
      mini_portile2 (~> 2.3.0)
    non-stupid-digest-assets (1.0.9)
      sprockets (>= 2.0)
    notiffany (0.1.1)
      nenv (~> 0.1)
      shellany (~> 0.0)
    originator (3.1)
      actionpack (>= 4.0)
      activerecord (>= 4.0)
    orm_adapter (0.5.0)
    pg (1.1.3)
    pry (0.11.3)
      coderay (~> 1.1.0)
      method_source (~> 0.9.0)
    public_suffix (3.0.3)
    rack (2.0.5)
    rack-attack (5.4.1)
      rack (>= 1.0, < 3)
    rack-mini-profiler (1.0.0)
      rack (>= 1.2.0)
    rack-test (1.1.0)
      rack (>= 1.0, < 3)
    rails (5.2.1)
      actioncable (= 5.2.1)
      actionmailer (= 5.2.1)
      actionpack (= 5.2.1)
      actionview (= 5.2.1)
      activejob (= 5.2.1)
      activemodel (= 5.2.1)
      activerecord (= 5.2.1)
      activestorage (= 5.2.1)
      activesupport (= 5.2.1)
      bundler (>= 1.3.0)
      railties (= 5.2.1)
      sprockets-rails (>= 2.0.0)
    rails-assets-jquery (2.2.4)
    rails-dom-testing (2.0.3)
      activesupport (>= 4.2.0)
      nokogiri (>= 1.6)
    rails-html-sanitizer (1.0.4)
      loofah (~> 2.2, >= 2.2.2)
    railties (5.2.1)
      actionpack (= 5.2.1)
      activesupport (= 5.2.1)
      method_source
      rake (>= 0.8.7)
      thor (>= 0.19.0, < 2.0)
    rake (12.3.1)
    ransack (2.0.1)
      actionpack (>= 5.0)
      activerecord (>= 5.0)
      activesupport (>= 5.0)
      i18n
    rb-fsevent (0.10.3)
    rb-inotify (0.9.10)
      ffi (>= 0.5.0, < 2)
    request_store (1.4.1)
      rack (>= 1.4)
    responders (2.4.0)
      actionpack (>= 4.2.0, < 5.3)
      railties (>= 4.2.0, < 5.3)
    ruby_dep (1.5.0)
    rubyzip (1.2.2)
    sass (3.6.0)
      sass-listen (~> 4.0.0)
    sass-listen (4.0.0)
      rb-fsevent (~> 0.9, >= 0.9.4)
      rb-inotify (~> 0.9, >= 0.9.7)
    sassc (1.12.1)
      ffi (~> 1.9.6)
      sass (>= 3.3.0)
    sassc-rails (1.3.0)
      railties (>= 4.0.0)
      sass
      sassc (~> 1.9)
      sprockets (> 2.11)
      sprockets-rails
      tilt
    select2-rails (3.5.10)
      thor (~> 0.14)
    selenium-webdriver (3.14.1)
      childprocess (~> 0.5)
      rubyzip (~> 1.2, >= 1.2.2)
    shellany (0.0.1)
    simple_form (4.0.1)
      actionpack (>= 5.0)
      activemodel (>= 5.0)
    slim (4.0.1)
      temple (>= 0.7.6, < 0.9)
      tilt (>= 2.0.6, < 2.1)
    slim-rails (3.2.0)
      actionpack (>= 3.1)
      railties (>= 3.1)
      slim (>= 3.0, < 5.0)
    sprockets (3.7.2)
      concurrent-ruby (~> 1.0)
      rack (> 1, < 3)
    sprockets-rails (3.2.1)
      actionpack (>= 4.0)
      activesupport (>= 4.0)
      sprockets (>= 3.0.0)
    sshkit (1.17.0)
      net-scp (>= 1.1.2)
      net-ssh (>= 2.8.0)
    temple (0.8.0)
    thin (1.7.2)
      daemons (~> 1.0, >= 1.0.9)
      eventmachine (~> 1.0, >= 1.0.4)
      rack (>= 1, < 3)
    thor (0.20.0)
    thread_safe (0.3.6)
    tilt (2.0.8)
    turbolinks (5.2.0)
      turbolinks-source (~> 5.2)
    turbolinks-source (5.2.0)
    tzinfo (1.2.5)
      thread_safe (~> 0.1)
    uglifier (4.1.19)
      execjs (>= 0.3.0, < 3)
    uniform_notifier (1.11.0)
    warden (1.2.7)
      rack (>= 1.0)
    websocket-driver (0.7.0)
      websocket-extensions (>= 0.1.0)
    websocket-extensions (0.1.3)
    xpath (3.2.0)
      nokogiri (~> 1.8)

PLATFORMS
  ruby

DEPENDENCIES
  airbrussh
  alchemy-devise!
  alchemy-richmedia-essences!
  alchemy_cms!
  autoprefixer-rails
  better_errors
  binding_of_caller
  bootsnap
  bullet
  byebug
  capistrano
  capistrano-alchemy
  capistrano-bundler
  capistrano-postgresql
  capistrano-rails
  capistrano-rbenv
  capistrano-rbenv-install
  capistrano-safe-deploy-to
  capistrano-secrets-yml
  capybara (>= 2.15)
  chromedriver-helper
  exception_notification
  fast_blank
  guard-rails
  jquery-turbolinks
  lol_dba
  pg
  rack-attack
  rack-mini-profiler
  rails (~> 5.2.1)
  rails-assets-jquery (~> 2)!
  responders
  sassc-rails
  selenium-webdriver
  slim-rails
  thin
  turbolinks
  uglifier

RUBY VERSION
   ruby 2.5.3p105

BUNDLED WITH
   1.16.6
@westonganger
Copy link
Contributor Author

westonganger commented Oct 20, 2018

Okay so I accidentally named my module sample_model when it should have been named sample_models and everything inside the module referred to sample_model. This included the incorrect :controller key which was the issue here.

Current behaviour:
Accessing the pages via the URL was working correctly with the exception of the navigation not showing up. I assume this was because it falls back to the default alchemy defined controller if one is not found.

Desired behaviour:
It would be better if the register_module method would throw an error if the specified :controller is not defined. Instead of simply not showing the navigation link.

@tvdeyen
Copy link
Member

tvdeyen commented Oct 25, 2018

Could you provide an example app that is showing the issue? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants