Fixed elements are only rendered in preview frame if Page is published

[robinboening]

Steps to reproduce

1. set up and create a fixed element on a page
2. see it does not render in the preview frame
3. publish the Page
4. see the element appearing in the preview frame

Expected behavior

The fixed element should be rendered in the preview frame right after its creation.

Actual behavior

After creating the fixed element it does not render in the preview frame. The Page needs to be published before it appears.

System configuration

• Alchemy Version: main
• Rails Version: 6

[robinboening]

Just as a side note: Tis is not related to the big Ingredient restructuring because I've noticed this behaviour before #2061 was merged.

[robinboening]

I just found the reason for this behaviour. The docs suggest to render fixed elements based on @page. @page is not the draft version though, hence the need to publish before actually seeing the element in the preview.

At the moment I am not sure what the best solution is.

[robinboening]

Currently, the render_elements helper is the piece to ensure pulling elements from @page.draft_version in preview mode.
To me it seems like this distinction is currently made on a level too high, but I might not see potential side-effects if we move this down to a lower level, like the controller.

A wild idea to always deal with the draft version in the preview

class Alchemy::Admin::PagesController < ResourcesController
  def load_resource
    @page = PageVersion.eager_load(page: :language).find_by(page_id: params[:id])
  end
end

This definitely breaks a lot of thinks and I can not imagine the impact, but it doesn't feel wrong to me.

@tvdeyen what are your thoughts (not only on this idea, but in general)?

[robinboening]

After a quick discussion with @tvdeyen he pointed me to use render_elements fixed: true. It is intentional that @page is always the published version.